Skip to content

Store worker's PID when a job is started #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Nov 13, 2020
Merged

Store worker's PID when a job is started #258

OCA-git-bot merged 1 commit into from
Nov 13, 2020
+25 −0

Conversation

@guewen
Copy link
Member

@guewen guewen commented Oct 1, 2020

Add a field in the "queue_job" model to store the worker pid.
No usage for new besides "logging" for debugging (helps to find which
process to investigate in case a job is stuck).
Later, it may be useful to improve the recovery of job that stay in the
wrong state when the job runner restarts.

Closes #177

Store worker's PID when a job is started
b21ce12 
Add a field in the "queue_job" model to store the worker pid.
No usage for new besides "logging" for debugging (helps to find which
process to investigate in case a job is stuck).
Later, it may be useful to improve the recovery of job that stay in the
wrong state when the job runner restarts.

Closes OCA#177
@guewen guewen requested a review from sbidoul October 1, 2020 15:31
sbidoul
sbidoul approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding with one ear while listening to talks with the other ?

Thanks for implementing this !

@guewen
Copy link
Member Author

guewen commented Nov 13, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 13, 2020

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2020
@OCA-git-bot
Merge PR #258 into 13.0
6b158fe 
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 13, 2020

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2020
@OCA-git-bot
Merge PR #258 into 13.0
1d9e26e 
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 13, 2020

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 205c39b into OCA:13.0 Nov 13, 2020
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 13, 2020

Congratulations, your PR was merged at 4ae3e86. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[idea] store worker PID on the queue.job record when starting a job

4 participants

@guewen @OCA-git-bot @simahawk @sbidoul