[13.0][IMP] queue_job: check that queue_job_notify trigger exists in db #264
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @guewen, |
nilshamerlinck
changed the title
lmignon
approved these changes
Oct 20, 2020
guewen
reviewed
Oct 20, 2020
queue_job/jobrunner/runner.py
Outdated
| ("queue_job", "queue_job_notify"), | ||
| ) | ||
| if cr.fetchone()[0] != 3: # INSERT, DELETE, UPDATE | ||
| _logger.debug( |
Member
There was a problem hiding this comment.
Since having the module installed without the trigger is never normal, should we log with warn or error level?
Contributor
There was a problem hiding this comment.
Good catch.... IMO we should log with error level.
Contributor
Author
There was a problem hiding this comment.
makes sense! fixed
nilshamerlinck
force-pushed
the
13.0_check_trigger
branch
from
d67c111 to
3dceec3
Compare
Member
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 35fbf96. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could save time in cases such as #262 :)