Skip to content

Conversation

@guewen
Copy link
Member

@guewen guewen commented Oct 29, 2020

"record.sudo().with_delay().foo()" generates a job that will be run
as sudo, keeping the current user, following the new implementation of
sudo/with_user of 13.0.

Closes #271

@guewen
Copy link
Member Author

guewen commented Nov 2, 2020

What is this travis failure on the branch? it passes on the pull request :/

@sebalix
Copy link
Contributor

sebalix commented Nov 5, 2020

The build displays on top, could be related:

/home/travis/.travis/job_stages: line 900: syntax error near unexpected token `fi'
/home/travis/.travis/job_stages: line 900: `fi'

Rebase maybe?

@guewen
Copy link
Member Author

guewen commented Nov 5, 2020

The build displays on top, could be related:

@sebalix
But this "Travis CI - Branch" job is bogus, generally we don't have both "Branch" and "Pull Request", but only "Pull Request".
IMO it should be ignored.

"record.sudo().with_delay().foo()" generates a job that will be run
as sudo, keeping the current user, following the new implementation of
sudo/with_user of 13.0.
@guewen
Copy link
Member Author

guewen commented Nov 13, 2020

It would be cleaner to store the su flag in the jsonified recordset actually. I'll update my PR.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@guewen guewen closed this Nov 13, 2020
@guewen
Copy link
Member Author

guewen commented Nov 13, 2020

I'll reopen another implementation.

@guewen
Copy link
Member Author

guewen commented Nov 13, 2020

It would be cleaner to store the su flag in the jsonified recordset actually. I'll update my PR.

New implementation in #281, which brings a nice refactoring.
cc @TDu @sebalix @simahawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep sudo() flag

5 participants