[13.0] Optimize queue.job creation #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
force-pushed
the
13.0-optimize-job-create
branch
2 times, most recently
from
75f9b70 to
ea57079
Compare
simahawk
reviewed
Feb 2, 2021
simahawk
approved these changes
Feb 2, 2021
Several fields on queue.job are initialized using computed fields, then never changed again. On creation of a queue.job record, we'll have an initial INSERT + at least one following UPDATE for the computed fields. Replace all the stored computed fields by a raw initialization of the values in `Job.store()` when the job is created, so we have only a single INSERT. Highlights: * as channel is no longer a compute/inverse field, override_channel is useless, I dropped it (actually the same value was stored in both channel and override_channel as the channel field was stored) * one functional diff is that now, when changing a channel on a job.function, the channel is no longer synchronized on existing jobs, it will be applied only on new jobs: actually this is an improvement, because it was impossible to change the channel of a job function in a large queue_job table as it meant writing on all the done/started jobs * searching the queue.job.function is now cached, as each job using the same will run a query on queue_job_function
guewen
force-pushed
the
13.0-optimize-job-create
branch
from
ae18c50 to
bb88d1e
Compare
Member
Author
|
Added a small benchmark in the description |
TDu
approved these changes
Feb 3, 2021
Contributor
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 15dc56f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fields on queue.job are initialized using computed fields,
then never changed again. On creation of a queue.job record, we'll have
an initial INSERT + at least one following UPDATE for the computed
fields.
Replace all the stored computed fields by a raw initialization of the
values in
Job.store()when the job is created, so we have only a singleINSERT.
Highlights:
useless, I dropped it (actually the same value was stored in both
channel and override_channel as the channel field was stored)
job.function, the channel is no longer synchronized on existing jobs,
it will be applied only on new jobs: actually this is an improvement,
because it was impossible to change the channel of a job function
in a large queue_job table as it meant writing on all the done/started
jobs
same will run a query on queue_job_function
Rough benchmark when generating jobs for ddmrp buffers (it includes some base
time to fetch the ddmrp buffers too). 9191 jobs were created: