Skip to content

[14.0] Migrate queue_job_cron #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 2 commits into from
Apr 22, 2021
Merged

[14.0] Migrate queue_job_cron #315

OCA-git-bot merged 2 commits into from
Apr 22, 2021

Conversation

@codingforfun
Copy link
Contributor

@codingforfun codingforfun commented Feb 25, 2021

No description provided.

@codingforfun codingforfun mentioned this pull request Feb 25, 2021
Closed
9 tasks
@fshah-initos fshah-initos force-pushed the 14.0-queue-job-cron branch from 0196ed8 to 33e8481 Compare March 3, 2021 09:53
@fshah-initos
Copy link

fshah-initos commented Mar 3, 2021

@ALL can someone please review this PR?

simahawk
simahawk requested changes Mar 3, 2021
View reviewed changes
@simahawk simahawk changed the title 14.0 queue job cron [14.0] Migrate queue_job_cron Mar 3, 2021
@simahawk
Copy link
Contributor

simahawk commented Mar 3, 2021

@ALL can someone please review this PR?

where is yours? 😉

@codingforfun codingforfun force-pushed the 14.0-queue-job-cron branch from 33e8481 to ef5aef9 Compare March 3, 2021 18:52
@codingforfun
Copy link
Contributor Author

codingforfun commented Mar 3, 2021

@ALL can someone please review this PR?

where is yours? wink

I don’t know if I understand the question right, but I think you are asking who is responsible here. This is we have different roles in the team here. I made the PR because I needed it urgently for a project, but my co-workers are looking at a bunch of OCA modules for migration to 14.0 anyways so I asked them to take care, respond to question etc.

@codingforfun
Copy link
Contributor Author

codingforfun commented Mar 3, 2021

pre-commit fails because of a change done in 085d5ba

@codingforfun codingforfun force-pushed the 14.0-queue-job-cron branch from ef5aef9 to bb004bd Compare March 3, 2021 21:15
@simahawk
Copy link
Contributor

simahawk commented Mar 4, 2021

@ALL can someone please review this PR?

where is yours? wink

I don’t know if I understand the question right, but I think you are asking who is responsible here. This is we have different roles in the team here. I made the PR because I needed it urgently for a project, but my co-workers are looking at a bunch of OCA modules for migration to 14.0 anyways so I asked them to take care, respond to question etc.

Indeed it was for @fshah-initos. I was trying to encourage him to drop a review 😉

simahawk
simahawk reviewed Mar 4, 2021
View reviewed changes
@codingforfun codingforfun force-pushed the 14.0-queue-job-cron branch from bb004bd to 048d1cb Compare March 4, 2021 07:44
simahawk
simahawk reviewed Mar 4, 2021
View reviewed changes
@fshah-initos fshah-initos force-pushed the 14.0-queue-job-cron branch from 048d1cb to 555e541 Compare March 8, 2021 05:57
@fshah-initos
Copy link

fshah-initos commented Mar 16, 2021

Hi @simahawk
Can you please review the PR?

simahawk
simahawk requested changes Mar 16, 2021
View reviewed changes
@fshah-initos
Copy link

fshah-initos commented Mar 23, 2021

@simahawk I have implemented the changes suggested. Will you please review it?

@simahawk
Copy link
Contributor

simahawk commented Mar 23, 2021

@fshah-initos good, thank you.
One last step: squash the last 2 commits and re-word the 1st one as [MIG] queue_job_cron: Migration to 13.0:

@fshah-initos fshah-initos force-pushed the 14.0-queue-job-cron branch from a19aead to dca7862 Compare April 5, 2021 07:18
@fshah-initos
Copy link

fshah-initos commented Apr 5, 2021 •
edited
Loading

Hi @simahawk
I have squash the commit and re-word it. Can this be merged?

@simahawk
Copy link
Contributor

simahawk commented Apr 6, 2021

Hi @simahawk
I have squash the commit and re-word it. Can this be merged?

maybe you can re-review and add your review? :)

@fshah-initos
Copy link

fshah-initos commented Apr 8, 2021

@ALL Is it possible to merge this PR?

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 8, 2021

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@fshah-initos
Copy link

fshah-initos commented Apr 14, 2021

Can someone from the maintainers please merge the PR?

@fshah-initos
Copy link

fshah-initos commented Apr 22, 2021

It would be great if somone could merge this PR.

@simahawk
Copy link
Contributor

simahawk commented Apr 22, 2021

@fshah-initos this comment is not attended #315 (comment)
Not blocking now but remember it next time 😉

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 22, 2021

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-315-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 37bdd63 into OCA:14.0 Apr 22, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 22, 2021

Congratulations, your PR was merged at 9fe4153. Thanks a lot for contributing to OCA. ❤️

@simahawk
Copy link
Contributor

simahawk commented May 25, 2022

/ocabot migration queue_job_cron

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone May 25, 2022
@etobella etobella mentioned this pull request Feb 14, 2023
Merged
ThomasBinsfeld added a commit to acsone/queue that referenced this pull request May 15, 2023
@ThomasBinsfeld
[FIX] queue_job_cron: preserve cron user
96b9c5e 
From OCA#315
@ThomasBinsfeld ThomasBinsfeld mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+1 more reviewer

@fshah-initos fshah-initos fshah-initos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@codingforfun @fshah-initos @simahawk @OCA-git-bot