Skip to content

[FIX] 14.0 doctests hidden errors #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 5 commits into from
May 19, 2021
Merged

[FIX] 14.0 doctests hidden errors #338

OCA-git-bot merged 5 commits into from
May 19, 2021

Conversation

@PieterPaulussen
Copy link
Contributor

@PieterPaulussen PieterPaulussen commented Apr 21, 2021 •
edited
Loading

At the moment, a doctest that fails is not registered in the output of the test results.
I have tested this hypothesis here: #336 where the tests do not fail, even though there is a clear error present!

@PieterPaulussen PieterPaulussen changed the title Fix/doctests hidden errors [FIX] 14.0 doctests hidden errors Apr 21, 2021
@StefanRijnhart
Copy link
Member

StefanRijnhart commented Apr 21, 2021

Oh, but this way we are stuck again with the meaningless test names, which is why Nils used a wrapper class...

2021-04-21 13:08:02,987 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,989 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,990 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,990 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...

@PieterPaulussen
Copy link
Contributor Author

PieterPaulussen commented Apr 29, 2021 •
edited
Loading

I have refactored the tests a bit and now the output looks like:

2021-04-29 11:06:09,567 22509 INFO odoo odoo.addons.queue_job.tests.common: Starting OdooDocTestCase.runTest ... 
2021-04-29 11:06:09,567 22509 INFO odoo odoo.addons.queue_job.tests.common: Running tests for odoo.addons.queue_job.jobrunner.channels.ChannelManager

@PieterPaulussen PieterPaulussen mentioned this pull request May 3, 2021
Closed
StefanRijnhart
StefanRijnhart reviewed May 3, 2021
View reviewed changes
@StefanRijnhart
Copy link
Member

StefanRijnhart commented May 3, 2021

@nilshamerlinck what do you think of this solution to the problem of doctest failures going unnoticed?

@guewen
Copy link
Member

guewen commented May 19, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 19, 2021

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-338-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b1912c7 into OCA:14.0 May 19, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 19, 2021

Congratulations, your PR was merged at b1912c7. Thanks a lot for contributing to OCA. ❤️

@simahawk simahawk mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PieterPaulussen @StefanRijnhart @guewen @OCA-git-bot @nilshamerlinck