Skip to content

[FIX] queue_job: Migrations raising errors #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Jun 29, 2021
Merged

[FIX] queue_job: Migrations raising errors #356

OCA-git-bot merged 1 commit into from
Jun 29, 2021

Conversation

@etobella
Copy link
Member

@etobella etobella commented Jun 22, 2021

When executing OpenUpgrade with a database that didn't have queue_job but a module change on 13.0 required it, several errors where raised (I don't know why, but OpenUpgrade executed the migrations). In order to solve them, I had to change the scripts applying this changes

pedrobaeza
pedrobaeza reviewed Jun 22, 2021
View reviewed changes
queue_job/migrations/13.0.3.2.0/pre-migration.py Outdated


def migrate(cr, version):
if not column_exists(cr, "queue_job", "record_ids"):
Copy link
Member

@pedrobaeza pedrobaeza Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this column will exist ever. It seems a one2many/many2many field.

Copy link
Member Author

@etobella etobella Jun 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the problem is that the table does not exist, modified checking the existance of the table

@etobella etobella changed the title [FIX] queue_jobs: Migrations raising errors [FIX] queue_job: Migrations raising errors Jun 22, 2021
@etobella etobella force-pushed the 13.0-fix-migrations branch from ae671fa to cb99f27 Compare June 22, 2021 13:15
@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 22, 2021
@etobella etobella mentioned this pull request Jun 22, 2021
Closed
1 task
@etobella etobella force-pushed the 13.0-fix-migrations branch from cb99f27 to 3b3652e Compare June 22, 2021 13:58
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 27, 2021

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@guewen
Copy link
Member

guewen commented Jun 29, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 29, 2021

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-356-by-guewen-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2021
@OCA-git-bot
Merge PR #356 into 13.0
f8bdbae 
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 29, 2021

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-356-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48a97e0 into OCA:13.0 Jun 29, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 29, 2021

Congratulations, your PR was merged at 48a97e0. Thanks a lot for contributing to OCA. ❤️

@dzungtran89 dzungtran89 mentioned this pull request Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewen guewen guewen approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

4 participants

@etobella @OCA-git-bot @guewen @pedrobaeza