Skip to content

[14.0][MIG] - queue_job_subscribe #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Sep 16, 2021
Merged

[14.0][MIG] - queue_job_subscribe #359

OCA-git-bot merged 1 commit into from
Sep 16, 2021

Conversation

@sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Jul 9, 2021

No description provided.

@sbejaoui sbejaoui force-pushed the 14.0-queue_job_subscribe-sbj branch from 5efa961 to a756d10 Compare July 9, 2021 12:36
rousseldenis
rousseldenis approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@BT-cserra
Copy link

BT-cserra commented Sep 16, 2021 •
edited
Loading

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

@sbejaoui sbejaoui force-pushed the 14.0-queue_job_subscribe-sbj branch from a756d10 to d9e0a72 Compare September 16, 2021 07:40
@sbejaoui
Copy link
Contributor Author

sbejaoui commented Sep 16, 2021

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

Hi @BT-cserra , it's fixed now

@BT-cserra
Copy link

BT-cserra commented Sep 16, 2021

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

Hi @BT-cserra , it's fixed now

Many thanks :)

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2021

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-cserra
Copy link

BT-cserra commented Sep 16, 2021

Hello @rousseldenis can you please trigger a merge on this one if it's fine for you?

@rousseldenis
Copy link
Contributor

rousseldenis commented Sep 16, 2021

Hello @rousseldenis can you please trigger a merge on this one if it's fine for you?

Unfortunately, don't have power here :-)

@OCA/core-maintainers

@dreispt
Copy link
Member

dreispt commented Sep 16, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2021

@dreispt The merge process could not start, because of exception 403 Must have admin access to view repository collaborators..

@dreispt
Copy link
Member

dreispt commented Sep 16, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2021

@dreispt The merge process could not start, because of exception 403 Must have admin access to view repository collaborators..

@guewen
Copy link
Member

guewen commented Sep 16, 2021

What is this error?

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2021

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-359-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 04b6340 into OCA:14.0 Sep 16, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2021

Congratulations, your PR was merged at eb83285. Thanks a lot for contributing to OCA. ❤️

@BT-cserra
Copy link

BT-cserra commented Sep 17, 2021

@rousseldenis @dreispt @guewen many thanks!

@rousseldenis
Copy link
Contributor

rousseldenis commented Sep 17, 2021

What is this error?

/ocabot merge nobump

That's a bug reported recently as GitHub API access rights has changed.

@simahawk
Copy link
Contributor

simahawk commented May 25, 2022

/ocabot migration queue_job_subscribe

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone May 25, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request May 25, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

+2 more reviewers

@BT-cserra BT-cserra BT-cserra approved these changes

@BT-aestebanez BT-aestebanez BT-aestebanez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

8 participants

@sbejaoui @BT-cserra @OCA-git-bot @rousseldenis @dreispt @guewen @simahawk @BT-aestebanez