Skip to content

[MIG] base_import_async: Migration to 14.0 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 2 commits into from
Aug 11, 2021
Merged

[MIG] base_import_async: Migration to 14.0 #366

OCA-git-bot merged 2 commits into from
Aug 11, 2021

Conversation

@simahawk
Copy link
Contributor

@simahawk simahawk commented Aug 10, 2021

take over and fix #351.

Contains a small improvement on tests.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 10, 2021

Hi @simahawk! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

rvalyi
rvalyi approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simahawk
Copy link
Contributor Author

simahawk commented Aug 11, 2021

the builds are all green, not sure why is not update here. Since this is the same as #351 that was approved, I merge.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 11, 2021

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-366-by-simahawk-bump-patch, awaiting test results.

@simahawk simahawk mentioned this pull request Aug 11, 2021
Closed
@OCA-git-bot OCA-git-bot merged commit 29e41fd into OCA:14.0 Aug 11, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 11, 2021

Congratulations, your PR was merged at 3c97ddc. Thanks a lot for contributing to OCA. ❤️

@simahawk
Copy link
Contributor Author

simahawk commented May 25, 2022

/ocabot migration base_import_async

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone May 25, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request May 25, 2022
Closed
9 tasks
@simahawk
Copy link
Contributor Author

simahawk commented May 25, 2022

/ocabot migration test_base_import_async

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@simahawk @OCA-git-bot @rvalyi @BT-jcamacho