Skip to content

Conversation

@guewen
Copy link
Member

@guewen guewen commented Nov 1, 2021

This is the work from @romi477 from #378 rebased on 15.0

@guewen guewen force-pushed the 15.0-mig-queue_job branch from 16fc887 to c47ceac Compare November 1, 2021 16:09
@ventor-dev
Copy link

@guewen so you will finish it or @romi477 should do smth? We need this module for our customer...

@guewen guewen force-pushed the 15.0-mig-queue_job branch from 47cb1e4 to 75f9e13 Compare November 1, 2021 19:22
@pedrobaeza
Copy link
Member

@guewen maybe you need to run the copier template (https://github.com/OCA/oca-addons-repo-template) over 15.0 for having the proper metafiles.

@guewen guewen force-pushed the 15.0-mig-queue_job branch from 95b1bb0 to a8784ac Compare November 1, 2021 19:49
@guewen
Copy link
Member Author

guewen commented Nov 1, 2021

maybe you need to run the copier template (https://github.com/OCA/oca-addons-repo-template) over 15.0 for having the proper metafiles.

Thanks @pedrobaeza! I fixed the base files now.

Reading the logs, it looks like it tries to install queue_job, which is a dependency of test_queue_job. The pip installable wheel for queue_job does not exist yet. @sbidoul did you see something like this already?

Run oca_install_addons
+ setuptools-odoo-get-requirements --include-addons --addons-dir .
+ cat test-requirements.txt
odoo-addon-queue_job>=15.0dev,<15.1dev
odoo>=15.0a,<15.1dev
requests
+ pip install -r test-requirements.txt
Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi
ERROR: Could not find a version that satisfies the requirement odoo-addon-queue_job<15.1dev,>=15.0dev (from versions: none)
ERROR: No matching distribution found for odoo-addon-queue_job<15.1dev,>=15.0dev
Error: Process completed with exit code 1.

@sbidoul
Copy link
Member

sbidoul commented Nov 1, 2021

It's a bug. Addons of the current repo should not be added to test-requirements.txt. I'll look into it. (acsone/setuptools-odoo#67)

@etobella
Copy link
Member

etobella commented Nov 1, 2021

Just one question. Can we delete test_queue_job and use odoo_test_helper in order to create the models in the tests. Something similar to https://github.com/OCA/edi/blob/14.0/edi_oca/tests/test_consumer_mixin.py ?

@sbidoul
Copy link
Member

sbidoul commented Nov 1, 2021

OCA/oca-ci#16 should fix it. We can restart the tests here as soon as the oca-ci images are rebuilt.

@sbidoul
Copy link
Member

sbidoul commented Nov 1, 2021

🍏

@guewen
Copy link
Member Author

guewen commented Nov 2, 2021

Wow, many thanks @sbidoul.

@guewen
Copy link
Member Author

guewen commented Nov 2, 2021

@etobella Why not, if anyone has time to dedicate to this...

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@guewen
Copy link
Member Author

guewen commented Nov 2, 2021

@guewen so you will finish it or @romi477 should do smth? We need this module for our customer...

@ventor-dev He can review and approve this PR :)

@ventor-dev
Copy link

@guewen @sbidoul when do you think that can be merged?

Also will it be also published to Odoo Apps?

@guewen
Copy link
Member Author

guewen commented Nov 2, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-384-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d704b84 into OCA:15.0 Nov 2, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8168ca0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants