[14.0][IMP] queue_job: use a widget in eta field in queue job tree view #388
Conversation
pedrobaeza
changed the title
|
If the remaining time is less a day, are hours displayed as well? |
|
it's showing
cc @moylop260 |
|
I think that limits a bit the usefulness, as you want to see the exact hour for being executed, but I let the rest to give their opinion. |
fernandahf
force-pushed
the
14.0-set-widget-date-queue-eta-fer
branch
from
9ec3596 to
c56817c
Compare
|
It would be nice if it shows "in 4 minutes", but I find Today too large. Having the information that a job is executed in 22 or 24 days is not really decisive, but in 2 minutes or 6 hours is. So I don't find this to be an improvement. I like the idea though and thanks for proposing it. |
|
Oh I didn't see it was beside the other one. So my only concern is the place it takes. Maybe add a visibility? hidden by default? |
fernandahf
force-pushed
the
14.0-set-widget-date-queue-eta-fer
branch
from
c56817c to
0f72422
Compare
|
I hid the field by default. cc @moylop260 |
fernandahf
force-pushed
the
14.0-set-widget-date-queue-eta-fer
branch
from
0f72422 to
1954a8e
Compare
|
There is an error in https://github.com/vauxoo-dev/queue/runs/4156961482?check_suite_focus=true
Could you review it, please? cc @moylop260 |
fernandahf
force-pushed
the
14.0-set-widget-date-queue-eta-fer
branch
from
1954a8e to
ec173cf
Compare
|
Is there something to do with my side in this PR? |
|
No, I was waiting for a second review as we are supposed to do. Sorry for the inconvenience and thank you for your PR /ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d64e42f. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Description of the issue/feature this PR addresses:
There is no issue, otherwise an improvement in queue job tree view, in order to user identifies clearly remaining days of
ETAof queue job (in case of have ETA)Also, this PR disables lint
duplicate-xml-fieldsdue to in v14.0 is allowed.Current behavior before PR:
Queue job tree view showing
ETAfield with datetime.Desired behavior after PR is merged:
Queue job tree view showing
ETAfield with remaining days widget, user can see clearly remaining days to the job is executed.-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr