Skip to content

[14.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 14.0 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 20 commits into from
May 3, 2022
Merged

[14.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 14.0 #393

OCA-git-bot merged 20 commits into from
May 3, 2022

Conversation

@anothingguy
Copy link
Contributor

@anothingguy anothingguy commented Dec 3, 2021

No description provided.

etobella and others added 18 commits December 2, 2021 11:23
@etobella @anothingguy
[ADD] queue_job_batch
048cdf0 
[UPD] Update queue_job_batch.pot
@LoisRForgeFlow @anothingguy
[11.0][FIX] queue_job_batch: view all in the systray not working
0746e2e
@LoisRForgeFlow @anothingguy
[11.0][FIX] queue_job_batch:
ceeb5cd 
* incorrect sintax in security rule
* change missleading name of security rule
@OCA-git-bot @anothingguy
queue_job_batch 11.0.1.1.1
0088abc
@OCA-git-bot @anothingguy
[UPD] README.rst
098e3a7
@LoisRForgeFlow @anothingguy
[12.0][MIG] queue_job_batch:
30ec11b 
standard migration and some little ux improvements: now hide
button is a fa-check button that on click just marks as read
the batch, do not navigate to it and updates immediately
the systray.

[UPD] Update queue_job_batch.pot
@OCA-git-bot @anothingguy
[UPD] README.rst
a45004d 
[UPD] Update queue_job_batch.pot
@qgroulard @anothingguy
[12.0] [FIX] Allow users from group queue_job_batch_user to write on …
337b07e 
…batches
@OCA-git-bot @anothingguy
queue_job_batch 12.0.1.0.1
325a2f1
@OCA-git-bot @anothingguy
[UPD] README.rst
301b93d
@ypapouin @anothingguy
Added translation using Weblate (French)
be35cc2
@ypapouin @anothingguy
Translated using Weblate (French)
c782378 
Currently translated at 100.0% (61 of 61 strings)

Translation: queue-12.0/queue-12.0-queue_job_batch
Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_batch/fr/
@etobella @anothingguy
[ADD] test_queue_job_batch
275d241 
[UPD] Update test_queue_job_batch.pot
@OCA-git-bot @anothingguy
[UPD] README.rst
a201497
@OCA-git-bot @anothingguy
[UPD] README.rst
fa3a582
@LoisRForgeFlow @anothingguy
[12.0][MIG] test_queue_job_batch
fde9eec 
[UPD] Update test_queue_job_batch.pot
@OCA-git-bot @anothingguy
[UPD] README.rst
185c0ad
@ypapouin @anothingguy
Added translation using Weblate (French)
0518e7e
@anothingguy anothingguy mentioned this pull request Dec 3, 2021
Closed
9 tasks
@anothingguy anothingguy changed the title 14.0 mig queue job batch [14.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 14.0 Dec 3, 2021
@anothingguy anothingguy force-pushed the 14.0-mig-queue_job_batch branch 2 times, most recently from fd18636 to d68c726 Compare December 3, 2021 09:06
@anothingguy anothingguy force-pushed the 14.0-mig-queue_job_batch branch from d68c726 to 91153c0 Compare December 3, 2021 09:58
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 8, 2022

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@olaf-wagner
Copy link

olaf-wagner commented Apr 6, 2022

Everything seems to be ok. Can anybody merge it?

@jordancoest
Copy link

jordancoest commented May 2, 2022

Everything seems to be ok. Can anybody merge it?

We are planning to use this PR. It seems ok for us too.
Is it ok to be merged ?

@simahawk
Copy link
Contributor

simahawk commented May 2, 2022

@guewen @etobella wondering: I guess we'll able to avoid using batches once #154 reaches v14, no?

@simahawk
Copy link
Contributor

simahawk commented May 2, 2022

@guewen @etobella wondering: I guess we'll able to avoid using batches once #154 reaches v14, no?

In any case we can merge this meanwhile, unless you see any incompatibility.

@guewen
Copy link
Member

guewen commented May 3, 2022

In any case we can merge this meanwhile, unless you see any incompatibility.

I ensured dependencies and batches are not incompatible, fine with me.

wondering: I guess we'll able to avoid using batches once #154 reaches v14, no?

I checked some time ago, I think both can be used a bit differently, in a batch of jobs, you can add jobs after having created the batch record, whereas with dependencies, you have to build the group with the API, then enqueue them all at once. I'm not sure if batches are used to accumulate jobs created from different requests/transactions, that would be something you can't do with dependencies.

@guewen
Copy link
Member

guewen commented May 3, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 3, 2022

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-393-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a31a9f2 into OCA:14.0 May 3, 2022
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 3, 2022

Congratulations, your PR was merged at 61402fc. Thanks a lot for contributing to OCA. ❤️

@simahawk
Copy link
Contributor

simahawk commented May 25, 2022

/ocabot migration queue_job_batch
/ocabot migration test_queue_job_batch

@OCA-git-bot OCA-git-bot modified the milestone: 14.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewen guewen guewen approved these changes

+2 more reviewers

@leemannd leemannd leemannd approved these changes

@jordancoest jordancoest jordancoest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.