[RFC] jobrunner cli #409
Merged
[RFC] jobrunner cli #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With this, there is no need for queue_job in server_wide_modules. |
sbidoul
force-pushed
the
14.0-jobrunner-cli-sbi
branch
from
ef61552 to
f415ec6
Compare
Member
Author
|
This seems to work well in our first tests. I think we can merge this as it is non-intrusive. I'll document it when we have more experience in production. |
guewen
approved these changes
Apr 29, 2022
Member
guewen
left a comment
guewen
left a comment
There was a problem hiding this comment.
Very good indeed for k8s-style infrastructure. Thanks!
We've run full loop with the old odoo-job-runner start script (don't remember the exact name) 😆
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at dab2bcb. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/!\ This is very rough and mostly untested. So just an idea so far.I wonder if running the job runner in a standalone process could be a solution to the problem of running a single job runner in a multi-node deployment.
We could then let the responsibility of running one replica of the job runner to the orchestrator (say, k8s), and we don't need ensure it's a singleton ourselves.
Use with
env ODOO_RC=odoo.cfg python -m odoo.addons.queue_job.jobrunner.