Skip to content

[MIG][15.0] queue_job_cron to version 15.0 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Apr 29, 2022
Merged

[MIG][15.0] queue_job_cron to version 15.0 #410

OCA-git-bot merged 1 commit into from
Apr 29, 2022

Conversation

@JoanMForgeFlow
Copy link
Contributor

@JoanMForgeFlow JoanMForgeFlow commented Mar 1, 2022

Standard migration to version 15.0

@JoanMForgeFlow JoanMForgeFlow force-pushed the 15.0-mig-queue_job_cron branch from 0df6d93 to 103456e Compare March 1, 2022 08:30
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 1, 2022
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

mariadforgeflow
mariadforgeflow approved these changes Mar 11, 2022
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 11, 2022

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk
simahawk approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

simahawk commented Mar 11, 2022

/ocabot merge nobump

@simahawk
Copy link
Contributor

simahawk commented Mar 11, 2022

/ocabot migration queue_job_cron

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 11, 2022

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 11, 2022
@OCA-git-bot
Merge PR #410 into 15.0
f08e2f2 
Signed-off-by simahawk
@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 11, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 11, 2022
Closed
10 tasks
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 11, 2022

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link

AaronHForgeFlow commented Apr 29, 2022

I think the CI failed because of an infrastructure thing. Probably retrying the merge will succeed. Can you do so @simahawk ?

@simahawk
Copy link
Contributor

simahawk commented Apr 29, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 29, 2022

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fbe33ad into OCA:15.0 Apr 29, 2022
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 29, 2022

Congratulations, your PR was merged at 4502fe5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+2 more reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JoanMForgeFlow @OCA-git-bot @simahawk @AaronHForgeFlow @mariadforgeflow