[14.0] queue_job: use parent channel if configured #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotho
reviewed
Mar 11, 2022
sebalix
reviewed
Mar 11, 2022
guewen
approved these changes
Mar 11, 2022
Member
guewen
left a comment
guewen
left a comment
There was a problem hiding this comment.
This behavior is exactly the one I would expect in all situations.
Thanks!
Use case: * you have a root channel per scope/app (eg: root.edi) * you have several sub channels (eg: root.edi.ubl.sales, root.edi.gs1.delivery) * you want to configure capacity only for the main channel "root.edi" Before this change, the channel manager falls back on root channel. However, if you have a specific parent channel configured it sounds a good idea to use it.
simahawk
force-pushed
the
14-channel-parent-fallback
branch
from
6739c3d to
96c9d9b
Compare
Contributor
Author
Cool. I've just dropped the try/except as it's useless now. |
Contributing since a while... :)
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 43cdb78. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
root.edi.gs1.delivery)
Before this change, the channel manager falls back on root channel,
and you get flooded w/ warning log entries like "unknown channel....".
However, if you have a specific parent channel configured
it sounds a good idea to use it.
NOTE: using
parent_fallbackflag is just an attempt to not break places where this feat is not desiderable.Also, I might fail to see why this behavior was not supported before: any remark is welcomed :)
@guewen can I have your insights please? 🙏