Skip to content

[16.0][FW] queue_job: multiple ports from 14.0 #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 2 commits into from
Nov 1, 2022
Merged

[16.0][FW] queue_job: multiple ports from 14.0 #471

OCA-git-bot merged 2 commits into from
Nov 1, 2022

Conversation

@baimont
Copy link
Contributor

@baimont baimont commented Oct 19, 2022 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 19, 2022

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@baimont baimont mentioned this pull request Oct 19, 2022
Closed
@baimont baimont marked this pull request as ready for review October 19, 2022 20:54
@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 20, 2022
@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 20, 2022

This is not changing anything right now. What is needed AFAIK is the module dependency, but not the server_wide_modules change.

@baimont
Copy link
Contributor Author

baimont commented Oct 20, 2022

This is not changing anything right now. What is needed AFAIK is the module dependency, but not the server_wide_modules change.

I'll adapt soon

@baimont baimont changed the title [16.0][FW] [14.0][FIX] queue_job: Update documentation to remove unnecessary addon (base_sparse_field) from server_wide_modules. [DRAFT][16.0][FW] [14.0][FIX] queue_job: Update documentation to remove unnecessary addon (base_sparse_field) from server_wide_modules. Oct 20, 2022
@baimont baimont force-pushed the oca-port-pr-453-from-14.0-to-16.0 branch from 626a736 to c8ff72b Compare October 20, 2022 08:18
@baimont baimont changed the title [DRAFT][16.0][FW] [14.0][FIX] queue_job: Update documentation to remove unnecessary addon (base_sparse_field) from server_wide_modules. [16.0][FW] queue_job: multiple ports from 14.0 Oct 20, 2022
rvalyi
rvalyi approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it changed the README and changed it back again, but this was done with these 2 steps in v14 so I think it's okay to just cherry-pick the 2 commits the way it is done in this PR.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 24, 2022

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@guewen
Copy link
Member

guewen commented Nov 1, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 1, 2022

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-471-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 1, 2022
@OCA-git-bot
Merge PR #471 into 16.0
3d4879b 
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 1, 2022

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-471-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5ae5e0 into OCA:16.0 Nov 1, 2022
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 1, 2022

Congratulations, your PR was merged at c544484. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

7 participants

@baimont @OCA-git-bot @pedrobaeza @guewen @rvalyi @sbidoul @victoralmau