[16.0][FIX] Patch Request._get_session_and_dbname to get db from URL

[hugosantosred]

In servers with multiple databases db is not captured from URL when processing jobs in /queue_job/runjob

With this patch db is set from the db param in URL when calling the runjob endpoint

Fixes #503

---

Maybe this monkey patch is not the most elegant or efficient solution, but this is the only way that I've managed to set the right db in order to call the petition with the request._serve_db method after the http.py complete refactor in v16.

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[hugosantosred]

Pre-commit is failing because of isort problem. Fixed by updating copier template in #505

[StefanRijnhart]

Thanks! I agree that monkeypatching should be avoided if possible. Is the db argument populated in https://github.com/OCA/queue/blob/94bd236/queue_job/controllers/main.py#L74? In that case, maybe it helps to insert a line there that also assigns the db attribute to the request.

[hugosantosred]

@StefanRijnhart At that point, the db argument is populated, but the problem is that the request is already served with the _serve_nodb method, because the request.db is not populated here: https://github.com/odoo/odoo/blob/16.0/odoo/http.py#L1989

In the requests that are getting served with the _serve_nodb method, there is not env available, and setting the request.db does nothing.

[zuher83]

Work with me 🙂 Thanks

[davejames]

functional review, works well here in a multi-db scenario

[guewen]

Thanks for the fix!
Also, thanks for checking if avoiding a monkey patch was possible. Sadly not, but at least it is applied very narrowly.

[guewen]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-504-by-guewen-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 72f7c98. Thanks a lot for contributing to OCA. ❤️