[16.0][FWD][FIX] queue_job: fix Delayable.__repr__ #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that sometimes jobs doesn't have a job_method and the __repr__ failed
simahawk
changed the title
sebalix
approved these changes
Feb 28, 2023
Contributor
|
Hi @guewen, |
Contributor
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Feb 28, 2023
Contributor
|
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-516-by-simahawk-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Contributor
Author
|
I'll fwd port changes from #519 before merging this, also because it seems this change was integrated in the chain dependencies mgmt. |
Contributor
Author
|
it was already in v15 here #487 I'll port that change w/ the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that sometimes jobs doesn't have a job_method and the repr failed
FWD port of #440
With better commit msg.
As the commit msg won't match I'd blacklist that PR for oca-port.
No need to backport to v15.