-
-
Notifications
You must be signed in to change notification settings - Fork 532
[14.0] queue_job_cron_jobrunner: avoid concurrent access on ir.cron #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] queue_job_cron_jobrunner: avoid concurrent access on ir.cron #611
Conversation
cd8cbda to
993e6bb
Compare
|
@ivantodorovich did you get similar issue on your odoo instances ? |
As odoo add a lock while running cron task we should only try to write on it. If the cron is running while create new queue job records we will wait next call.
993e6bb to
38b4ed0
Compare
Hey @petrus-v , @damdam-s 👋🏻 it's nice to see your names here Actually, I originally developed this module for Odoo 15.0, relying on cron triggers. I've never used this module in |
ivantodorovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense 👍🏻
Thanks for your prompt reply, history regarding this topic and review ! Always a pleasure to see your name on so many projects around ! see you soon and happy end of year :) |
|
This PR has the |
|
are you aware of #612? |
no I'm not... but I'm not sure how much it's related. As mentionned by @ivantodorovich this module in version 14.0 do not rely on So creating a new job in this version try to write on the ir.cron which is probably running to the row is lock, at the end the whole transaction get rollback before this PR. |
guewen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 34e80c7. Thanks a lot for contributing to OCA. ❤️ |
As odoo add a lock while running cron task we should only try to write
on it. If the cron is running while create new queue job records
we will wait next call.