Skip to content

Conversation

@OCA-git-bot
Copy link
Contributor

Hi @guewen, @ivantodorovich,
some modules you are maintaining are being modified, check this out!

@florentx florentx force-pushed the 17.0_port branch 5 times, most recently from 9463909 to 2b0c033 Compare December 27, 2024 17:04
@hbrunn
Copy link
Member

hbrunn commented Mar 21, 2025

@florentx please fix conflicts

@florentx
Copy link
Contributor Author

@florentx please fix conflicts

Done. Thank you.

@ecino
Copy link

ecino commented May 8, 2025

There are again some conflicts on this, but the changes would be appreciated!

sbidoul and others added 14 commits May 8, 2025 12:47
By default, odoo never runs the same cron job in parallel. This commit uses the identity key mechanism to enforce this mechanism when a cron job is run as a queue job. This behaviour can be controlled by a new setting on the cron definition but is activated by default to keep the original behaviour
Configuration of randomized retry intervals is not possible due to the formatting checks not being updated.
This should fix it.
So the time required to compute such fields by the ORM is taken into
account when the 'date_done' and 'exec_time' values are set on the job.
Starting from 16.0, we should call `env.flush_all()` instead of
`env["base"].flush()`, like it is done few lines below.
* use FIFO, firt createad job will be treat first
* if priority are different it take the precedent

Yet we are not using channel priority into account
Otherwise, you cannot use any channel other than default (
root.ir_cron)
@ecino
Copy link

ecino commented Jun 3, 2025

Can we merge?

@florentx
Copy link
Contributor Author

florentx commented Jun 6, 2025

Yes, this PR is 5 months old, and it is only port of changes from other branches. It needs someone with write access to merge it.

@sbidoul ? @rvalyi ?

@rvalyi
Copy link
Member

rvalyi commented Jun 6, 2025

@florentx I use queue modules in many projects. But I don't claim to master it enough to assume merging such large changes in my name. I'm an historical "core committer", but I only merge things I'm very sure about to avoid doing any harm.

In my opinion it would make more sense you propose yourself as a project PSC and get the commit rights granted. May be other PSCs will not agree but I think you have enough skills and responsabiltities to step in.

You could make a PR here to apply:
https://github.com/OCA/repo-maintainer-conf

@hbrunn
Copy link
Member

hbrunn commented Jun 6, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-731-by-hbrunn-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d512a58. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit afae818 into OCA:17.0 Jun 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.