-
-
Notifications
You must be signed in to change notification settings - Fork 532
[17.0][UPD] Forward port changes from 14/15/16 #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @guewen, @ivantodorovich, |
9463909 to
2b0c033
Compare
|
@florentx please fix conflicts |
Done. Thank you. |
|
There are again some conflicts on this, but the changes would be appreciated! |
By default, odoo never runs the same cron job in parallel. This commit uses the identity key mechanism to enforce this mechanism when a cron job is run as a queue job. This behaviour can be controlled by a new setting on the cron definition but is activated by default to keep the original behaviour
Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.
So the time required to compute such fields by the ORM is taken into account when the 'date_done' and 'exec_time' values are set on the job.
Starting from 16.0, we should call `env.flush_all()` instead of `env["base"].flush()`, like it is done few lines below.
* use FIFO, firt createad job will be treat first * if priority are different it take the precedent Yet we are not using channel priority into account
Otherwise, you cannot use any channel other than default ( root.ir_cron)
|
Can we merge? |
|
@florentx I use queue modules in many projects. But I don't claim to master it enough to assume merging such large changes in my name. I'm an historical "core committer", but I only merge things I'm very sure about to avoid doing any harm. In my opinion it would make more sense you propose yourself as a project PSC and get the commit rights granted. May be other PSCs will not agree but I think you have enough skills and responsabiltities to step in. You could make a PR here to apply: |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d512a58. Thanks a lot for contributing to OCA. ❤️ |
Following PRs were missing in 17.0 branch. They are now forward ported from earlier branches (14, 15 and 16):
wait_dependenciesstate #629