[18.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 18.0 #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule * change missleading name of security rule
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray. [UPD] Update queue_job_batch.pot
[UPD] Update queue_job_batch.pot
[UPD] Update test_queue_job_batch.pot
[UPD] Update test_queue_job_batch.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-16.0/queue-16.0-test_queue_job_batch Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-test_queue_job_batch/
florentx
approved these changes
Jan 8, 2025
| "company_id": company_id, | ||
| } | ||
| ) | ||
| return self.sudo().create(vals).with_user(self.env.uid) |
Contributor
There was a problem hiding this comment.
I wonder if this syntax can be better:
Suggested change
| return self.sudo().create(vals).with_user(self.env.uid) | |
| return self.sudo().create(vals).sudo(False) |
Comment on lines
+90
to
+93
| company_id = self.env.user.company_id.id | ||
|
|
||
| if "company_id" in self.env.context: | ||
| company_id = self.env.context["company_id"] |
Contributor
There was a problem hiding this comment.
Can also be:
Suggested change
| company_id = self.env.user.company_id.id | |
| if "company_id" in self.env.context: | |
| company_id = self.env.context["company_id"] | |
| company_id = self.env.context.get("company_id", self.env.user.company_id.id) |
Contributor
|
This PR is still under development. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HELP IS NEEDED
I’ve started the migration and JS code analysis.
The “messaging” JS code was heavily refactored starting v17 with this commit:
I’m not familiar with the module and don’t know how it’s expected to work.
I’ve checked the JS changes and write some pseudo code:
https://github.com/OCA/queue/pull/733/files#diff-bc23bdd925614b2acfed835f19bb33416f7a6f4ee37a15938971d2c309aa2a0e
ping @ivantodorovich