Skip to content

Conversation

@florentx
Copy link
Contributor

@florentx florentx commented Jan 17, 2025

This enhancement is needed to write more accurate tests when the delayed method is context-sensitive.

We had a bug not identified during tests because of this :(

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx florentx changed the title [14.0][IMP] queue_jobs: perform_enqueued_jobs should filter the context [14.0][IMP] queue_job: perform_enqueued_jobs should filter the context Jan 17, 2025
@florentx florentx force-pushed the 14.0_trap_context branch 2 times, most recently from a2d94e3 to dd8c852 Compare January 24, 2025 19:13
StefanRijnhart
StefanRijnhart previously approved these changes Feb 5, 2025
@StefanRijnhart StefanRijnhart dismissed their stale review March 19, 2025 19:28

Dismissing my review as per other reviewer's comment.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-738-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 200e979. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 622586d into OCA:14.0 Apr 30, 2025
7 checks passed
@florentx florentx deleted the 14.0_trap_context branch May 8, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants