Skip to content

Conversation

@vincent-hatakeyama
Copy link
Contributor

Without this fix, if db_replica_host is set, Odoo might pass a readonly database cursor and the FOR UPDATE in the method would fail.

Without this fix, if db_replica_host is set, Odoo might pass a readonly
database cursor and the FOR UPDATE in the method would fail.
@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-742-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 26beed3 into OCA:18.0 Jan 24, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0767459. Thanks a lot for contributing to OCA. ❤️

@vincent-hatakeyama vincent-hatakeyama deleted the feature/18.0/queue_job/fix-readonly-route branch January 24, 2025 15:58
@aallouche
Copy link

Thanks for the quick merge! Much appreciated.

@StefanRijnhart
Copy link
Member

@vincent-hatakeyama Can I ask you, I'm curious why this is necessary. https://github.com/odoo/odoo/blob/b2d709b/odoo/http.py#L701-L703 seems to imply that the cursor will default to read/write. Where is the default determined as True?

@StefanRijnhart
Copy link
Member

@vincent-hatakeyama Oh, never mind. Found it in https://github.com/odoo/odoo/blob/b2d709b/odoo/http.py#L863, when auth='none'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants