[17.0][IMP] queue_job: add Job to recordset ctx #758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the UUID is enough for retrieving the original Job instance via ``Job.load(env, uuid)`` and read its attributes. But the returned Job instance is actually a different one than the Job instance that triggered the function, because loading creates a new instance instead. Therefore, operations beside reading the Job attributes will result in unexpected behaviors (for example: dependencies are not stored correctly). This commit allows retrieving the Job instance from the context itself to make it usable from within the running method.
simahawk
requested changes
Apr 8, 2025
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
I'm not sure to understand why you need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the UUID is enough for retrieving the original Job instance via
Job.load(env, uuid)and read its attributes. But the returned Job instance is actually a different one than the Job instance that triggered the function, because loading creates a new instance instead. Therefore, operations beside reading the Job attributes will result in unexpected behaviors (for example: dependencies are not stored correctly).This commit allows retrieving the Job instance from the context itself to make it usable from within the running method.