[FIX] queue_job: Adapted migration to properly delete the invalid que… #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @guewen, |
Member
AnizR
approved these changes
Apr 11, 2025
Contributor
AnizR
left a comment
AnizR
left a comment
There was a problem hiding this comment.
Thanks, for fixing this issue!
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at bd3aded. Thanks a lot for contributing to OCA. ❤️ |
Member
|
@baguenth do you plan to forward port? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3e5645b we got rid of the garbage collector logic for stuck queue jobs and therefore deactivated the old cron job, which was handling the garbage collection in the past.
Seems like the migration added, to deactivate the cron job, doesn't properly work. At least in my environments the cron job is still active and lead to error messages in the log like:
Since we actually don't need this cron job anymore, I guess we can simply remove it entirely.