Skip to content

Conversation

@florentx
Copy link
Contributor

@florentx florentx commented Jun 2, 2025

These parts were marked as deprecated since Odoo 12.0.

Also the comparison methods on Job are misleading:

  • the sorting_key returns a tuple containing a missing attribute seq --> AttributeError
  • so it means that this comparison never worked
  • and obviously, it is not used anywhere, it is just confusing
  • meaningful ordering happens on odoo.addons.queue_job.jobrunner.channels.ChannelJob

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx florentx marked this pull request as draft June 2, 2025 07:50
@florentx florentx marked this pull request as ready for review June 2, 2025 08:04
@florentx florentx changed the title [REF] queue_job: remove deprecated and not used methods [18.0][REF] queue_job: remove deprecated and not used methods Jun 2, 2025
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@amh-mw amh-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed (improved code coverage on negative lines of code 😁), functionally tested (ran several hundred varied data import queue jobs) and organically tested (fooled around with sorting in user interface).

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Jun 7, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-775-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6f6eab6. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 97bf1d0 into OCA:18.0 Jun 7, 2025
7 checks passed
@florentx florentx deleted the 18.0_rm_deprecated branch June 16, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants