Skip to content

Conversation

@zamberjo
Copy link
Member

Resolves #814

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sersanchus
Copy link

TSGTM. I have verified that these changes ensure the job will be re-enqueued indefinitely when max_retries is set to 0 and the worker dies unexpectedly (e.g., abrupt termination).

@zamberjo zamberjo marked this pull request as ready for review August 18, 2025 17:04
Copilot AI review requested due to automatic review settings August 18, 2025 17:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes handling of zero max_retries in job retry logic by treating zero as NULL to prevent premature job failure. The issue occurred when jobs with max_retries=0 were incorrectly marked as failed instead of being requeued.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zamberjo zamberjo force-pushed the fix/dead-jobs-max_retries branch from fb1f1c4 to fa39043 Compare August 19, 2025 08:44
@zamberjo zamberjo requested a review from sbidoul August 19, 2025 08:45
Copy link
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for your contribution!

@zamberjo zamberjo force-pushed the fix/dead-jobs-max_retries branch from fa39043 to 97f20e2 Compare August 19, 2025 14:48
@zamberjo zamberjo requested a review from amh-mw August 19, 2025 14:48
@zamberjo
Copy link
Member Author

@OCA/queue-maintainers Can this be merged?

@sbidoul
Copy link
Member

sbidoul commented Aug 20, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-816-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a7a4529 into OCA:17.0 Aug 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 357fbd0. Thanks a lot for contributing to OCA. ❤️

@sbidoul
Copy link
Member

sbidoul commented Aug 20, 2025

Backport to 16.0 in #817

@sbidoul
Copy link
Member

sbidoul commented Aug 20, 2025

And cherry-picked into #749 for 18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants