[18.0][MIG] repair_stock: Migration to 18.0 #77
Conversation
BhaveshHeliconia
force-pushed
the
18.0-mig-repair_stock
branch
from
7950e0c to
93dc8ba
Compare
|
Hi @HeliconiaSolutions could you cherry-pick this patch #90 here? |
|
@LoisRForgeFlow , please review.it's done. |
BhaveshHeliconia
force-pushed
the
18.0-mig-repair_stock
branch
from
4d42fac to
814fec8
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
LoisRForgeFlow
removed
the
stale
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
@BhaveshHeliconia Sorry for the slow review here.
Comparing v17 commit history with this PR, I still miss one more commit: 7e4ed99
Coud you add it?
|
@LoisRForgeFlow, Please Review. |
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
@BhaveshHeliconia Thanks! I still see on issue in the history
Could you fix the commit message of this commit to be "[MIG] repair_stock: Migration to 18.0"
`repair_id` is reserved to the stock.moves directly related to the execution of the repair order and has associated logic in odoo core code (like assigning the picking type) To avoid unexpected behaviors, we use `related_repair_id` to signal auxiliar stock moves that are not directly related to repair execution. To not break existing modules depending on it, support for `repair_id` is kept but it is recommended to remove in v18.
BhaveshHeliconia
force-pushed
the
18.0-mig-repair_stock
branch
from
a8044be to
dd5b56c
Compare
|
@LoisRForgeFlow : It's done now. Thanks, and sorry for the delay. |
|
/ocabot migration repair_stock |
|
@BhaveshHeliconia I still miss commits from v17 history, like this one 7e4ed99 |
This module has been migrated over several versions and has good tests coverage.
|
@LoisRForgeFlow : I've added it—thanks for pointing it out. Please check. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 69e33e8. Thanks a lot for contributing to OCA. ❤️ |
6 participants
No description provided.