[19.0][MIG] report_pdf_form #1107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of mapped() can raise an AttributeError if any field in the dot-separated path does not exist (e.g., a typo in the configuration). This would crash the report generation. It's better to handle this potential error gracefully, for instance by catching the exception and returning an empty recordset, which will result in an empty value for the field.
Changes made: - Properly handle many2one field formatting to prevent TypeError
Added SQL constraint to ensure that each ir.actions.report can only be associated with one PDF form template, preventing unpredictable behavior when multiple templates share the same report_name.
…de fields Added ace code editor widget with Python syntax highlighting to: - odoo_field_value field in field mapping - code field in variables
- Demo data for testing the module with sample configurations - Documentation on how to use demo data - Information about tools to create PDF form fields (docfly.com, LibreOffice Draw, Scribus)
…lity This commit adds several enhancements to the report_pdf_form module: - Add validation for dotted field paths with visual indicators - Add manual validation button for field mappings - Add PDF preview functionality with sample data - Improve demo data with deeper dotted path examples - Enhance configuration documentation with PDF upload clarification Co-authored-by: Akim Juillerat <akim.juillerat@camptocamp.com>
This commit fixes translation formatting issues by using .format() method instead of % formatting for all translation strings to comply with Odoo's translation best practices.
bosd
force-pushed
the
19.0-mig-report_pdf_form
branch
from
be36b59 to
26879bd
Compare
Comment on lines
+53
to
+56
| .. IMPORTANT:: | ||
| This is an alpha version, the data model and design can change at any time without warning. | ||
| Only for development or testing purpose, do not use in production. | ||
| `More details on development status <https://odoo-community.org/page/development-status>`_ |
Contributor
Author
There was a problem hiding this comment.
I think so.. This is the first migration. And have been adding some features.
Ci is 🔴 😿
Maybe later promote it to beta? Will check the requirements..
This commit moves the binding configuration from the ir.actions.report record to the actual report.pdf.form record, which is the proper location for the binding since the module inherits from ir.actions.report using _inherits. This ensures the demo report appears in the contact's print menu.
This commit fixes two issues: - Fix view error by changing 'help' attribute to 'title' for button with icon - Add required model_id field to test data to satisfy the required constraint - Keep model_id as required since it's needed for field validation functionality
This commit adds an onchange method to automatically populate the model_id field based on the report_id's model, making it easier to create PDF form configurations without manually setting the model.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit fixes translation formatting by using the % dictionary formatting method instead of .format() method to satisfy the linter requirements for proper translation handling in Odoo.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit updates all translation calls to use the direct _() function instead of self.env._() to satisfy the linter requirements for lazy translation formatting. Also imports _() in both model files.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit reverts to using self.env._() for translations as required by the linter (W8161 error), while keeping proper % formatting for the translation strings.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit changes the translation formatting from % dictionary method to .format() method to satisfy the linter requirements for proper lazy translation formatting.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit fixes translation calls in ir_actions_report.py to use direct _() instead of self.env._() for simple translation strings, and imports _() in the file.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit makes the dotted path validation more lenient by skipping validation when the model is not yet available during record creation, which fixes the test failure where validation runs before the model is properly linked.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit reverts to using self.env._ for simple translations as required by the linter (W8161 error), while keeping proper .format() method for parameterized translations.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit changes parameterized translations to use % dictionary formatting instead of .format() method to satisfy the linter requirements (W8302 error).
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit changes all translations to use the direct _() function instead of self.env._() to satisfy the linter requirements for lazy translation formatting (W8301 error).
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit uses the proper translation approach: - Use self.env._ with % formatting for parameterized translations (to satisfy W8161) - Use _() for simple translations (to satisfy W8301) - This approach should satisfy both linter requirements while allowing tests to pass.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> This commit uses self.env._ for all translations as required by the linter (W8161 error), including both simple and parameterized translations. Parameterized translations still use % formatting.
This commit makes the dotted path validation skip when the model is not yet available during record creation, which fixes the test failure where validation runs before the model is properly linked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration.
"Improvements" deliberatly made in seperate commits for cherry-picking