[MIG] auth_brute_force: Migrate to v11 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
11.0-auth_brute_force
branch
2 times, most recently
from
e80ed7c to
e7c24ef
Compare
92 tasks
yajo
force-pushed
the
11.0-auth_brute_force
branch
5 times, most recently
from
e7c24ef to
a59dd31
Compare
…1219) To fix OCA/server-tools#1125 I needed to refactor the addon. To whitelist IPs now you use a config parameter, which renders res.banned.remote model unneeded. The fix is affected by odoo/odoo#24183 and will not work until it gets fixed upstream due to the technical limitations implied.
- The `whitelisted` field needs to exist in view to be usable. - The correct class is `decoration-danger` for tree views.
…-tools#1251) Include HACK for odoo/odoo#24833, which explains the false positive problem we were having here: an addon being importable doesn't mean it is installed.
- Remove Python coding headers. - Remove v10 migration scripts. - Standard py2-py3 changes. - Do not encode POST data in tests, Odoo now uses `requests` for `HttpCase` connections.
yajo
force-pushed
the
11.0-auth_brute_force
branch
from
a59dd31 to
bb7db70
Compare
Member
Author
|
Not sure what's Github doing with this commit order:
But as you can see here, it's correctly done:
This should be ready to merge. |
yajo
requested review from
MiquelRForgeFlow,
chienandalu,
pedrobaeza and
rafaelbn
Member
|
I think it's because it's ordered by date, not by commit insertion. I have seen this before in other cases. |
pedrobaeza
approved these changes
May 22, 2018
Contributor
|
but you can edit the commit date of the migration commit and change it to a posterior date 😎 |
Member
Author
|
It's not my job to fix Github 😋 |
rafaelbn
approved these changes
May 25, 2018
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestsforHttpCaseconnections.@Tecnativa