[17.0][MIG] auth_api_key: Migration to 17.0. by chrisb-c01 · Pull Request #591 · OCA/server-auth

chrisb-c01 · 2023-12-16T14:27:27Z

No description provided.

…custom one from shopinvader

Get rid of keychain dependency

Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>

…v.mixin obj

Api key is now based on the new version of server env Key belong to a specifiv database that can be requested based on the domain name. Just setup the db_filter with "%d^" to filter based on domain name

… to manage auth api keys

Add a migration script to create the auth.api.key records from keys defined into the cfg file Provides a specific serction name builder to continue reading the key info from the same section as the one expected by the previous version

This reverts commit bb13b69.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_api_key/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-16.0/server-auth-16.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_api_key/

pedrobaeza · 2023-12-16T15:25:04Z

Isn't this a native feature since the integration of TOTP?

chrisb-c01 · 2023-12-17T11:07:05Z

Isn't this a native feature since the integration of TOTP?

Do you mean the ability for a user to generate an API key from their profile page? There is some overlap indeed, but imho there is still use for this addon.

You can (as an admin) centrally manage the API keys assigned to different users from the settings page.
Also having the auth='api_key' param on the controller allows you to permit authenticating using the API key but not just any user/password combination.

chrisb-c01 · 2023-12-17T11:13:13Z

auth_api_key/models/auth_api_key.py

+        return self._retrieve_api_key(key).user_id.id
+
+    def _clear_key_cache(self):
+        self.env.registry.clear_cache()


Unit tests were failing before because clearing the orm cache using clear_cache() is not available anymore in 17.0 on the cache object. It was removed in this commit with the introduction of multiple caches. Needed to call env.registry.clear_cache() instead. Might be useful for other migrations.

@chrisb-c01 Thanks for the details!

pedrobaeza · 2023-12-17T14:33:06Z

OK, IMO you should add that explanations to the README.

FrancoMaxime

LGTM

gurneyalex · 2024-01-26T06:51:57Z

/ocabot migration auth_api_key

gurneyalex · 2024-01-26T06:52:06Z

/ocabot merge nobump

OCA-git-bot · 2024-01-26T06:52:11Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-591-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-26T06:56:18Z

Congratulations, your PR was merged at cd9e49b. Thanks a lot for contributing to OCA. ❤️

lmignon and others added 30 commits December 16, 2023 15:13

New generic module du define REST services

f930718

auth_api_key: New module to provide authentication by api_key

ee660e5

auth_api_key: Remove useless code

d45cf20

Update the auth_api_key for keychan 10.0.2 (renamed method)

479e374

Fix the authentification method and show the user_id on the form

00d83d5

refactor code in order to use generic code from base_rest instead of …

648682d

…custom one from shopinvader

fix wrong name in selection box

bffe122

Since keychain 10.0.2.0.1 there is a default validation method

90f6942

Keychain removed

185c0bb

Get rid of keychain dependency

Update Readme with more details

b3630a0

Quick fix CONFIGURE.rst

8e4e467

Developmet status: Beta

0307905

[FIX] auth_api_key: fix api and flake8

f12ca09

[MIG] server_auth from 10 to 12

454a93f

auth_api_key: add description to model

46e3251

[CHG] auth_api_key is LGPL

ea150e8

Use consteq to compare keys

4c2af8e

Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>

[UPD] README.rst

02ca732

[IMP] ADD possibility to save api keys in database by using server.en…

7be81bf

…v.mixin obj

[FIX] login_name error

74dbb2c

[IMP] make auth_api_key compatible in multi-db

c6109aa

Api key is now based on the new version of server env Key belong to a specifiv database that can be requested based on the domain name. Just setup the db_filter with "%d^" to filter based on domain name

[UPD] README.rst

ab5095c

[FIX] auth_api_key: Fix tests according to last changes and add views…

f2088ae

… to manage auth api keys

[IMP] auth_api_key: Ensures backward compatibility

a808b5d

Add a migration script to create the auth.api.key records from keys defined into the cfg file Provides a specific serction name builder to continue reading the key info from the same section as the one expected by the previous version

[FIX] auth_api_key: Cache must be cleared if the user_id is modified

19b388f

[IMP] auth_api_key: Improves key field description

69de3d5

[UPD] README.rst

6870008

[IMP] auth_api_key: black, isort

b7c5c74

[MIG] auth_api_key: Migration to 13.0

305b70b

[UPD] Update auth_api_key.pot

db10be0

TDu and others added 10 commits December 16, 2023 15:13

Revert "Update translation files"

9217c74

This reverts commit bb13b69.

auth_api_key 15.0.1.1.1

0f34de1

Update translation files

3aff27a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_api_key/

[IMP] auth_api_key: pre-commit stuff

5ebe9be

[MIG] auth_api_key: Migration to 16.0

3c75dc1

[UPD] Update auth_api_key.pot

b9ad341

[UPD] README.rst

dbeb944

Update translation files

90d4072

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-16.0/server-auth-16.0-auth_api_key Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_api_key/

[UPD] README.rst

3f79341

[IMP] auth_api_key: pre-commit auto fixes

8003141

chrisb-c01 mentioned this pull request Dec 16, 2023

Migration to version 17.0 #571

Open

21 tasks

[MIG] auth_api_key: Migration to 17.0

19b09b4

chrisb-c01 force-pushed the 17.0-mig-auth_api_key branch from 538e178 to 19b09b4 Compare December 17, 2023 10:58

chrisb-c01 commented Dec 17, 2023

View reviewed changes

gurneyalex approved these changes Jan 8, 2024

View reviewed changes

gurneyalex mentioned this pull request Jan 8, 2024

[17.0][MIG] auth_api_key_server_env: Migration to 17.0 #598

Merged

FrancoMaxime approved these changes Jan 8, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 8, 2024

OCA-git-bot added this to the 17.0 milestone Jan 26, 2024

OCA-git-bot added the bot is merging ⏳ label Jan 26, 2024

OCA-git-bot merged commit 2e3b528 into OCA:17.0 Jan 26, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[17.0][MIG] auth_api_key: Migration to 17.0.#591

[17.0][MIG] auth_api_key: Migration to 17.0.#591
OCA-git-bot merged 65 commits intoOCA:17.0from
codeforward-bv:17.0-mig-auth_api_key

chrisb-c01 commented Dec 16, 2023

Uh oh!

pedrobaeza commented Dec 16, 2023

Uh oh!

chrisb-c01 commented Dec 17, 2023

Uh oh!

chrisb-c01 Dec 17, 2023

Uh oh!

FrancoMaxime Jan 8, 2024

Uh oh!

pedrobaeza commented Dec 17, 2023

Uh oh!

FrancoMaxime left a comment

Uh oh!

gurneyalex commented Jan 26, 2024

Uh oh!

gurneyalex commented Jan 26, 2024

Uh oh!

OCA-git-bot commented Jan 26, 2024

Uh oh!

OCA-git-bot commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

chrisb-c01 commented Dec 16, 2023

Uh oh!

pedrobaeza commented Dec 16, 2023

Uh oh!

chrisb-c01 commented Dec 17, 2023

Uh oh!

chrisb-c01 Dec 17, 2023

Choose a reason for hiding this comment

Uh oh!

FrancoMaxime Jan 8, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Dec 17, 2023

Uh oh!

FrancoMaxime left a comment

Choose a reason for hiding this comment

Uh oh!

gurneyalex commented Jan 26, 2024

Uh oh!

gurneyalex commented Jan 26, 2024

Uh oh!

OCA-git-bot commented Jan 26, 2024

Uh oh!

OCA-git-bot commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants