[19.0][MIG] mail_debranding: migrate #113

tishmen · 2025-10-19T13:32:20Z

Scope

mail_debranding

Depends on

None

Summary

Import mail_debrand history from OCA/mail 18.0 using git filter-repo (isolated path + rename to mail_debranding) and git am (authors/subjects preserved).
Migrate to Odoo 19; set version to 19.0.1.0.0; keep depends=["mail"].
Adjust any template/rendering changes for 19.0 if needed.

Temporary references

None

Pre-commit

Ran locally; auto-fixes committed separately as [IMP].

Tests

Local: ./odoo/odoo-bin -c odoo.conf -i mail_debranding --test-enable --log-level=info --stop-after-init
Notes: Verify mail notification and signup templates render; ensure “Powered by” link removal still holds.

Currently translated at 20.0% (1 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

There's no commits preservation, as the module doesn't serve as is on v9.

Currently translated at 80.0% (4 of 5 strings) Translation: social-14.0/social-14.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_debrand/fr_FR/

Currently translated at 80.0% (4 of 5 strings) Translation: social-14.0/social-14.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_debrand/it/

Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_debrand/

Currently translated at 100.0% (3 of 3 strings) Translation: social-17.0/social-17.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_debrand/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_debrand/

See odoo/odoo@9f65f1a Fixes ``` 2025-02-12 16:01:58,174 254 ERROR odoo odoo.addons.mail_debrand.tests.test_mail_debrand: FAIL: TestMailDebrand.test_default_debrand Traceback (most recent call last): File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 52, in test_default_debrand self._test_debrand_by_lang( File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 47, in _test_debrand_by_lang self.assertIn(term, body) AssertionError: 'Powered by' not found in Markup('\n<html>\n<head>\n ... ```

Currently translated at 100.0% (3 of 3 strings) Translation: mail-18.0/mail-18.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_debrand/tr/

tishmen · 2025-10-19T14:09:22Z

Hi @pedrobaeza, mail_debranding migration is ready for review.

Imported full history from OCA/mail 18.0, renamed across history mail_debrand → mail_debranding using git filter-repo, then applied with git am to preserve authors/subjects.
Migrated to Odoo 19; manifest set to 19.0.1.0.0; no extra deps beyond mail.
19.0 deltas applied in tests: use odoo.tools.urls.urljoin; switch to self.env._; replace deprecated toggle_active with action_unarchive.
Commit hygiene: first [IMP] pre-commit auto-fixes, then single [MIG] commit (squashed).

Pre-commit

Ran locally; clean.

Tests

Local run: ./odoo/odoo-bin -c odoo.conf -i mail_debranding --test-enable --log-level=info --stop-after-init

Please let me know if you want any additional adjustments. Thank you!

minhthie · 2025-11-09T13:32:16Z

Functional test looks good.

However, the phrase "Powered by Odoo" still appears on the login page. I know the module is about mail debranding but maybe it's good to handle them all at once.

tishmen · 2025-11-09T17:48:19Z

@minhthie That functionality is covered in the following pull request: #109

RyanTranAVB

LGTM, but do remove the comment before merging

mail_debranding/tests/test_mail_debrand.py

StefanRijnhart

Looking good! Care to fix that outdated comment?

tishmen · 2025-12-21T21:18:29Z

Sorry for the delay — I’ve updated the PR and removed the migration-only comment. Thanks for the review!

StefanRijnhart · 2025-12-21T21:22:49Z

Thanks! Please squash that commit into the migration commit (which introduces the comment removed in the last commit).

rven and others added 30 commits October 19, 2025 15:13

Translated using Weblate (Dutch)

14a010e

Currently translated at 20.0% (1 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/nl/

Translated using Weblate (French)

f22ecb3

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

Translated using Weblate (French)

f9cdb46

Currently translated at 100.0% (5 of 5 strings) Translation: social-13.0/social-13.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_debrand/fr/

[FIX] support all languages, no need of translations

fac804f

[UPD] README.rst

1f3355c

mail_debrand 13.0.2.0.0

a3d4ac5

[FIX] Fixed travis error.

6c4d477

[UPD] README.rst

a52450f

mail_debrand 13.0.2.0.1

6c4c9db

[MIG] mail_debrand

2715716

There's no commits preservation, as the module doesn't serve as is on v9.

OCA Transbot updated translations from Transifex

defd13a

[11.0][MIG] mail_debrand

744fbfb

[UPD] Update mail_debrand.pot

9631973

[IMP] mail_debrand: black, isort, prettier

12e5156

[MIG] mail_debrand: Migration to v14

9cc5b54

also precommit

e819ef6

k also send mail

c3bbf48

now taking the parent if is td

81b739d

k precommit

9fd8825

[FIX] fixed test

d92f91a

I have a fix for the issue, here: ursais/server-brand@6a3933f

597b63e

[UPD] Update mail_debrand.pot

f106e5c

[UPD] README.rst

61c7faf

Added translation using Weblate (French (France))

9021c02

Translated using Weblate (French (France))

af474e1

Currently translated at 80.0% (4 of 5 strings) Translation: social-14.0/social-14.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_debrand/fr_FR/

[FIX] mail_debrand: tolerate binary inputs, solve etree FutureWarning

c95712f

[FIX] mail_debrand: TypeError: object of type 'NoneType' has no len()

e65c512

mail_debrand 14.0.1.0.1

c42a766

Added translation using Weblate (Italian)

10db164

Translated using Weblate (Italian)

1e93c15

Currently translated at 80.0% (4 of 5 strings) Translation: social-14.0/social-14.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_debrand/it/

nguyenminhchien and others added 17 commits October 19, 2025 15:13

[MIG] mail_debrand: Migration to 17.0

7d6a064

Translated using Weblate (French)

d535b05

Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/fr/

[UPD] Update mail_debrand.pot

2904c76

[BOT] post-merge updates

5678f02

Update translation files

6247b04

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_debrand/

Translated using Weblate (Italian)

4c14a5e

Currently translated at 100.0% (3 of 3 strings) Translation: social-17.0/social-17.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_debrand/it/

[IMP] mail_debrand: pre-commit auto fixes

cce0518

[MIG] mail_debrand: Migration to 18.0

2499367

[UPD] Update mail_debrand.pot

2026226

[BOT] post-merge updates

17c1b62

Update translation files

8087b28

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_debrand/

[BOT] post-merge updates

5d07d94

Added translation using Weblate (German)

c9ab303

Added translation using Weblate (Turkish)

2353914

Translated using Weblate (Turkish)

7bb3ccc

Currently translated at 100.0% (3 of 3 strings) Translation: mail-18.0/mail-18.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_debrand/tr/

[IMP] mail_debranding: pre-commit auto fixes

50b8364

tishmen marked this pull request as ready for review October 19, 2025 13:59

tishmen force-pushed the 19.0-mig-mail_debranding branch from f629b8c to c0a183e Compare October 19, 2025 14:01

This was referenced Oct 19, 2025

Migration to version 19.0 #104

Open

Migration to version 19.0 OCA/mail#85

Open

RyanTranAVB approved these changes Dec 1, 2025

View reviewed changes

mail_debranding/tests/test_mail_debrand.py Outdated Show resolved Hide resolved

StefanRijnhart reviewed Dec 15, 2025

View reviewed changes

[MIG] mail_debranding: Migration to 19.0

e912dc0

tishmen force-pushed the 19.0-mig-mail_debranding branch from 58746a7 to e912dc0 Compare December 21, 2025 23:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[19.0][MIG] mail_debranding: migrate #113

[19.0][MIG] mail_debranding: migrate #113

Uh oh!

tishmen commented Oct 19, 2025

Uh oh!

tishmen commented Oct 19, 2025

Uh oh!

minhthie commented Nov 9, 2025

Uh oh!

tishmen commented Nov 9, 2025

Uh oh!

RyanTranAVB left a comment

Uh oh!

Uh oh!

StefanRijnhart left a comment

Uh oh!

tishmen commented Dec 21, 2025

Uh oh!

StefanRijnhart commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[19.0][MIG] mail_debranding: migrate #113

Are you sure you want to change the base?

[19.0][MIG] mail_debranding: migrate #113

Uh oh!

Conversation

tishmen commented Oct 19, 2025

Uh oh!

tishmen commented Oct 19, 2025

Uh oh!

minhthie commented Nov 9, 2025

Uh oh!

tishmen commented Nov 9, 2025

Uh oh!

RyanTranAVB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

tishmen commented Dec 21, 2025

Uh oh!

StefanRijnhart commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants