Skip to content

[IMP] server_environment: allow env variable conf#189

Merged
OCA-git-bot merged 1 commit intoOCA:17.0from
DynAppsNV:17.0-mig-server_environment
Jul 11, 2024
Merged

[IMP] server_environment: allow env variable conf#189
OCA-git-bot merged 1 commit intoOCA:17.0from
DynAppsNV:17.0-mig-server_environment

Conversation

@denaux
Copy link

@denaux denaux commented Jun 24, 2024

I would like to propose a forward port of one specific commit from v14. This opens up compatibility with Odoo.sh.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denaux thanks for your contrib.
Question: how have you ported the commit? Seems the original authorship is lost.
You should use cherry pick to preserve it. Could you check please?

@denaux denaux force-pushed the 17.0-mig-server_environment branch from f77ac73 to 38090e1 Compare June 27, 2024 08:14
@denaux
Copy link
Author

denaux commented Jun 27, 2024

@simahawk Thanks for the heads-up. This should be fixed now.

@simahawk
Copy link
Contributor

/ocabot merge minor

Thanks! Would you mind opening a PR for 14 and 15?

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-189-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 386cc0b into OCA:17.0 Jul 11, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 759299b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants