[9.0][database_cleanup] model purge broken

[florian-dacosta]

I think purging models not longer works, because of this : https://github.com/OCA/OCB/blob/9.0/openerp/addons/base/ir/ir_model.py#L147

Any ideas on how we could have it fix?
@hbrunn

[hbrunn]

you might want to elaborate on what the actual problem is

[florian-dacosta]

The models we want to delete are old ones and are not declared in the current available modules, so they are not loaded.
In the _prepare_update method, Odoo tries to access the model with self.env[record.model] which fails.

So we get an error of this kind :

File "/opt/ostore/odoo/parts/server-tools/database_cleanup/models/purge_models.py", line 94, in purge
.with_context(*_context_flags).unlink()
File "/opt/ostore/odoo/parts/odoo/openerp/api.py", line 248, in wrapper
return new_api(self, *args, *_kwargs)
File "/opt/ostore/odoo/parts/odoo/openerp/api.py", line 574, in new_api
result = method(self._model, cr, uid, self.ids, _args, *_old_kwargs)
File "/opt/ostore/odoo/parts/odoo/openerp/addons/base/ir/ir_model.py", line 147, in unlink
model.field_id._prepare_update()
File "/opt/ostore/odoo/parts/odoo/openerp/api.py", line 248, in wrapper
return new_api(self, _args, *_kwargs)
File "/opt/ostore/odoo/parts/odoo/openerp/addons/base/ir/ir_model.py", line 445, in _prepare_update
model = self.env[record.model]
File "/opt/ostore/odoo/parts/odoo/openerp/api.py", line 768, in getitem
return self.registry[model_name]._browse(self, ())
File "/opt/ostore/odoo/parts/odoo/openerp/modules/registry.py", line 84, in getitem
return self.models[model_name]
ValueError: "res.partner.address" while evaluating
u"self.purge(cr, uid, context.get('active_ids', []), context)"

[hbrunn]

now this is a message to work with. I'd suggest to override https://github.com/OCA/OCB/blob/9.0/openerp/addons/base/ir/ir_model.py#L439 in a way such that it does nothing if the model in question isn't available. Repeat for succeeding functions with similar behavior, and comment lavishly