Skip to content

Conversation

@GoodERPJeff
Copy link

No description provided.

@oca-clabot
Copy link

Hey @GoodERPJeff, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • Osoul (no github login found)
  • lily (no github login found)
  • Hugo Santos (no github login found)

Appreciation of efforts,
OCA CLAbot

@GoodERPJeff GoodERPJeff mentioned this pull request Oct 14, 2018
32 tasks
@elicoidal elicoidal added this to the 12.0 milestone Oct 14, 2018
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
some details

@@ -0,0 +1,53 @@
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1392 (review) : many remarks might apply here

batch processes.

The technical user must
- be inactive to avoid login

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add blank line

It allows you to bind a technical user on the company in order to use it in
batch processes.

The technical user must

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ":"

mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit http://odoo-community.org.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

'website': "http://acsone.eu",
'category': 'Hidden/Dependency',
'version': '12.0.1.0.0',
'license': 'AGPL-3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add cover image with screenshot

'summary': """
Add a technical user parameter on the company """,
'author': 'ACSONE SA/NV, Odoo Community Association (OCA)',
'website': "http://acsone.eu",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add copyright

@pedrobaeza
Copy link
Member

I'm not sure this module is still needed in v12, as now admin is a normal user.

@GoodERPJeff
Copy link
Author

the module is trying to manage user for cron job in each company. so I think odoo admin user will not cover this scenario.

@pedrobaeza
Copy link
Member

OK, I didn't know the details of the module.

@florian-dacosta
Copy link
Contributor

Is not the readme supposed to be generated automatically now? Or is it not mandatory?
@GoodERPJeff Will you adjust your PR with @elicoidal comments?

@pedrobaeza
Copy link
Member

Superseeded by #1560

@pedrobaeza pedrobaeza closed this Apr 17, 2019
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants