12.0 mig sentry #1415
Merged
12.0 mig sentry #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] sentry module * [FIX] updated sentry module according to PR comments
- [FIX] sentry: fixes missing `raven` library preventing loading of modules - [FIX] 2to3 script on py file - [FIX] add requirements.txt
sentry: It is not always possible to read commit information from a production environment. In those cases it is useful to be able to set a release version manually.
Member
|
CIs are red. |
Contributor
Author
|
can not get more details from CI. |
Member
|
The problem is the same for both: a lack of a Python library called
|
Contributor
Author
|
code testing coverage going down, how to improve this. |
Contributor
|
Add new unitests in the tests folder in order to cover the cases that is not tested |
sbidoul
approved these changes
Nov 17, 2018
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
(code review)
The global coverage of the repo drops because we start from an almost empty repo which has 100% coverage. This is not a problem for a migration, IMO so we can approve this.
Contributor
|
thanks. |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.