12.0 mig html text #1417
12.0 mig html text #1417
Conversation
* [8.0][html_text] Excerpt generator. This module adds a technical utility to allow the developer to get an excerpt from any HTML chunk. You can choose the maximum amount of words or characters if you want. See the README and inline docstrings for further details.
OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
[FIX] Tests [FIX] Do not test the specific exception [FIX] Do not test the specific exception
|
Hey @Dike90, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
LGTM |
|
@Dike90 have you signed the CLA? |
| return "" | ||
|
|
||
| # Get words | ||
| words = u"".join(doc.xpath("//text()")).split() |
There was a problem hiding this comment.
This will cause a problem if the html isn't using spaces around tags. e.g. <a>Test</a><b>Hello</b>. Best would be to use a space for joining.
There was a problem hiding this comment.
I don't agree, because i.e. This is a <b>test</b> still has an ending space after "a". On the other hand My<b>Long</b>Word is still one word.
There was a problem hiding this comment.
Then is it correct for all cases?
There was a problem hiding this comment.
You get problems when you use something like <div>, <p> or <td> tags. e.g. <div>Hello,</div><div>Ok</div>. But of course it's probably a edge case and can be fixed with html formatting.
Syncing from upstream OCA/server-tools (12.0)
11 participants
No description provided.