-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
12.0 mig html image url extractor #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex
|
Hey @MrFangD, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
elicoidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -0,0 +1,71 @@ | |||
| # Copyright 2016-2017 Jairo Llopis <jairo.llopis@tecnativa.com> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this file is not rendered properly in github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to 2018 everywhere
yajo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to some error in the past when migrating to v9, I just noticed the 1st commit 4a89640 is not attributed to me as the original author.
It's not your fault, nor anything too important, so I approve the PR, but I'd personally appreciate it if you can restore it.
Thanks!
|
@yajo on the migration to v9, the commit was correct. It has been later when the attribution was gone. |
|
Well, not sure when, but the commit in v9 branch is altered. It seems that PR was squashed on merge. |
|
Yes, it was on merge, not on the PR. @moylop260 squashed both commits on merge. |
|
Closing in favor of duplicated #1508, which is more complete. |
Syncing from upstream OCA/server-tools (14.0)
No description provided.