Skip to content

Conversation

@MrFangD
Copy link

@MrFangD MrFangD commented Nov 3, 2018

No description provided.

cubells and others added 12 commits November 3, 2018 14:49
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
@oca-clabot
Copy link

Hey @MrFangD, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • @MrFangD (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 3, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 3, 2018
32 tasks
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,71 @@
# Copyright 2016-2017 Jairo Llopis <jairo.llopis@tecnativa.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this file is not rendered properly in github.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 2018 everywhere

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to some error in the past when migrating to v9, I just noticed the 1st commit 4a89640 is not attributed to me as the original author.

It's not your fault, nor anything too important, so I approve the PR, but I'd personally appreciate it if you can restore it.

Thanks!

@pedrobaeza
Copy link
Member

@yajo on the migration to v9, the commit was correct. It has been later when the attribution was gone.

@yajo
Copy link
Member

yajo commented Nov 5, 2018

Well, not sure when, but the commit in v9 branch is altered. It seems that PR was squashed on merge.

@pedrobaeza
Copy link
Member

Yes, it was on merge, not on the PR. @moylop260 squashed both commits on merge.

@yajo
Copy link
Member

yajo commented Feb 14, 2019

Closing in favor of duplicated #1508, which is more complete.

@yajo yajo closed this Feb 14, 2019
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants