[12.0][MIG] base_name_search_improved #1419

wowerliu · 2018-11-03T08:27:23Z

No description provided.

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

- Descriptor: change __openerp__.py file to __manifest__.py also update module version from 9.0.1.0.0 to 11.0.1.0.0 - Update README using guideline - Views: replace view tag openerp to odoo and rename files to match guideline - Models - update imports from openerp to odoo - remove enconding line # -*- coding: utf-8 -*- - update to make it compatible - remove use of SUPERUSER_ID use sudo instead. - rename class name to make it match with guideline. - update methods to match api used in version 11.0 - fix pylint errors - replace use of non exist self._model with self._name - use `Model `is not None instead of if `Model` this becuase the last one is a empty recordset and this one was evaluate to False and never was patching the method. - apply changes resquested/suggested in the PR by the reviewers.

oca-clabot · 2018-11-03T08:27:26Z

Hey @wowerliu, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

mtbochaca (no github login found)
Druid Liu(刘震) (no github login found)
Katherine Zaoral (no github login found)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2018-11-03T13:23:49Z

Please check Travis.

elicoidal

Thanks for the contribution
some details + travis

elicoidal · 2018-11-04T09:01:53Z

base_name_search_improved/readme/CONFIGURE.rst

+Additional search fields can be configured at Settings > Technical > Database > Models,
+using the "Name Search Fields" field.
+
+.. figure:: https://raw.githubusercontent.com/OCA/server-tools/11.0/base_name_search_improved/images/image1.png


to be updated to v12

elicoidal · 2018-11-04T09:02:41Z

base_name_search_improved/readme/DESCRIPTION.rst

+Additionally, an Administrator can configure other fields to also lookup into.
+For example, Customers could be additionally searched by City or Phone number.
+
+.. figure:: https://raw.githubusercontent.com/OCA/server-tools/11.0/base_name_search_improved/images/image2.png


update here too

dreispt · 2018-11-05T15:30:47Z

base_name_search_improved/tests/test_name_search.py

+
+    def setUp(self):
+        super(NameSearchCase, self).setUp()
+        phone_field = self.env.ref('base.field_res_partner_phone')


Tests are failing because of this: the field XML Id changed to base.field_res_partner__phone

levkar · 2019-09-21T09:49:29Z

This error raises when search yields no results:

  File "/home/odoo/src/user/base_name_search_improved/models/ir_model.py", line 22, in _extend_name_results
    if result_count < limit:
TypeError: '<' not supported between instances of 'int' and 'NoneType'

mfhm95 · 2019-11-19T12:34:08Z

This error raises when search yields no results:

  File "/home/odoo/src/user/base_name_search_improved/models/ir_model.py", line 22, in _extend_name_results
    if result_count < limit:
TypeError: '<' not supported between instances of 'int' and 'NoneType'

how do you solve it ?

levkar · 2019-11-19T13:00:36Z

base_name_search_improved/models/ir_model.py

+
+def _extend_name_results(self, domain, results, limit):
+    result_count = len(results)
+    if result_count < limit:


Suggested change

if result_count < limit:

if not limit:

domain += [('id', 'not in', [x[0] for x in results])]

recs = self.search(domain)

results.extend(recs.name_get())

elif result_count < limit:

This patch solves the typeerror

Thank you very much dear

AaronHForgeFlow

👍 Functional review fine.

unique4 · 2020-05-17T04:12:23Z

I see all passed, could anyone merge this branch?

pedrobaeza · 2020-05-17T10:53:11Z

It requires 2 approvals.

conroyke56 · 2020-10-18T09:58:28Z

Any updates on this merge?

dreispt · 2021-08-20T10:20:59Z

/ocabot merge nobump

OCA-git-bot · 2021-08-20T10:21:07Z

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1419-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2021-08-20T10:52:25Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1419-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

github-actions · 2023-08-06T12:24:13Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

dreispt · 2023-08-11T10:02:18Z

/ocabot merge nobump

OCA-git-bot · 2023-08-11T10:02:32Z

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1419-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2023-08-11T12:47:04Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1419-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

github-actions · 2023-12-17T12:25:50Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Syncing from upstream OCA/server-tools (15.0)

dreispt and others added 16 commits November 3, 2018 14:39

base_name_search_improved: friendly and powerful name search

9eb74c1

Return all results from the several methods, ordered by best match

5d290c0

Test if additional domain is honored

e6754bb

Honor name_search additional domain

12e032e

Do not search on empty string. Fixes OCA#467

16a3784

Bump version

251782c

Fix small typo in readme

ffa5f04

[9.0] MIG Improved Name Search

5de4d63

# Please enter the commit message for your changes. Lines starting

526a156

OCA Transbot updated translations from Transifex

55913e6

[UPD] Update base_name_search_improved.pot

6522446

Translated using Weblate (Catalan)

edf6984

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

[UPD] Update base_name_search_improved.pot

5ebf382

[UPD] README.rst

f744923

[MIG] base_name_search_improved: Migration to 12.0

9f38c14

pedrobaeza added this to the 12.0 milestone Nov 3, 2018

OCA-git-bot mentioned this pull request Nov 3, 2018

Migration to version 12.0 #1368

Closed

32 tasks

elicoidal suggested changes Nov 4, 2018

View reviewed changes

dreispt reviewed Nov 5, 2018

View reviewed changes

[FIX] phone field XML Id changed on 12.0

1374af6

levkar reviewed Nov 19, 2019

View reviewed changes

AaronHForgeFlow approved these changes Dec 31, 2019

View reviewed changes

gurneyalex approved these changes Aug 20, 2021

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Aug 20, 2021

Merge PR #1419 into 12.0

facec43

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Aug 20, 2021

OCA-git-bot removed the bot is merging ⏳ label Aug 20, 2021

dreispt changed the title ~~12.0 mig base name search improved~~ [12.0][MIG] base_name_search_improved Dec 4, 2021

dreispt added the needs fixing label Dec 4, 2021

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 6, 2023

OCA-git-bot added the bot is merging ⏳ label Aug 11, 2023

OCA-git-bot added a commit that referenced this pull request Aug 11, 2023

Merge PR #1419 into 12.0

28ad7bf

Signed-off-by dreispt

OCA-git-bot removed the bot is merging ⏳ label Aug 11, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 13, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 17, 2023

github-actions bot closed this Jan 21, 2024

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#1419 from OCA/15.0

e811418

Syncing from upstream OCA/server-tools (15.0)

-    if result_count < limit:
+    if not limit:
+        domain += [('id', 'not in', [x[0] for x in results])]
+        recs = self.search(domain)
+        results.extend(recs.name_get())
+    elif result_count < limit:

Uh oh!

[12.0][MIG] base_name_search_improved #1419

[12.0][MIG] base_name_search_improved #1419

Uh oh!

Conversation

wowerliu commented Nov 3, 2018

Uh oh!

oca-clabot commented Nov 3, 2018

Uh oh!

pedrobaeza commented Nov 3, 2018

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

elicoidal Nov 4, 2018

Choose a reason for hiding this comment

Uh oh!

elicoidal Nov 4, 2018

Choose a reason for hiding this comment

Uh oh!

dreispt Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

levkar commented Sep 21, 2019

Uh oh!

mfhm95 commented Nov 19, 2019

Uh oh!

levkar Nov 19, 2019

Choose a reason for hiding this comment

Uh oh!

levkar Nov 19, 2019

Choose a reason for hiding this comment

Uh oh!

mfhm95 Nov 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

unique4 commented May 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented May 17, 2020

Uh oh!

conroyke56 commented Oct 18, 2020

Uh oh!

dreispt commented Aug 20, 2021

Uh oh!

OCA-git-bot commented Aug 20, 2021

Uh oh!

OCA-git-bot commented Aug 20, 2021

Uh oh!

github-actions bot commented Aug 6, 2023

Uh oh!

dreispt commented Aug 11, 2023

Uh oh!

OCA-git-bot commented Aug 11, 2023

Uh oh!

OCA-git-bot commented Aug 11, 2023

Uh oh!

github-actions bot commented Dec 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

mfhm95 Nov 19, 2019 •

edited

Loading

unique4 commented May 17, 2020 •

edited

Loading