[12.0][MIG] sql_request_abstract #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
AdriaGForgeFlow
force-pushed
the
12.0-mig-sql_request_abstract
branch
from
b039614 to
875cd9e
Compare
legalsylvain
approved these changes
Dec 14, 2018
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
code review of the diff from 11.0 (last commit) / No test.
LGTM and simple.
Thanks for porting this module ! 👍
bealdav
approved these changes
Feb 22, 2019
| @@ -0,0 +1,11 @@ | |||
| Inherit the model: | |||
|
|
|||
| from openerp import models | |||
Member
There was a problem hiding this comment.
LGTM, only old string here, thanks
MiquelRForgeFlow
approved these changes
Feb 26, 2019
Contributor
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Please, squash last commit
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
AdriaGForgeFlow
force-pushed
the
12.0-mig-sql_request_abstract
branch
from
c594bb8 to
c5af8d7
Compare
Member
|
Rebase needed? |
MiquelRForgeFlow
approved these changes
Feb 27, 2019
Contributor
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Normally when you squash, you rebase also at the same time haha
Member
I see more than one commit here I would do a rebase to OCA remote 11.0 @ageficent |
Contributor
|
@hveficent, @ageficent shouldn't squash commit history, only his commits. |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (13.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of module sql_request_abstract to v12