Skip to content

Conversation

@etobella
Copy link
Member

@etobella etobella commented Dec 26, 2018

Backport for profiler from #1369
@moylop260 @jbeficent

@etobella
Copy link
Member Author

Travis is failing due to #1466

@etobella etobella force-pushed the 11.0-mig-profiler branch 2 times, most recently from 6d6be53 to 2ecdda2 Compare December 27, 2018 15:20
@JordiBForgeFlow
Copy link
Member

@etobella now that #1466 is merged, can you rebase to check that Travis is green?

@etobella
Copy link
Member Author

@jbeficent Now it is green and rebased.

Copy link
Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have used it now for several months and works great!

@JordiBForgeFlow
Copy link
Member

@moylop260 this one LGTM. If you are good with it too we can merge!

@etobella
Copy link
Member Author

etobella commented Mar 1, 2019

I will apply commit 5355ab8 from v12 in order to make it similar,
Also, I made some tests in order to improve the coverage, maybe it is interesting to apply them on v12 @moylop260

@pedrobaeza pedrobaeza added this to the 11.0 milestone Mar 7, 2019
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash a bit the commit history of initial ones.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@etobella Could you squash ?

@etobella etobella force-pushed the 11.0-mig-profiler branch from 0eba7e0 to 98e43d9 Compare May 2, 2019 08:04
@etobella
Copy link
Member Author

etobella commented May 2, 2019

I have squashed my commits except the patching rpccalls, as it already exists on 12.0

@rousseldenis
Copy link
Contributor

@OCA/core-maintainers

@pedrobaeza pedrobaeza merged commit 8e17343 into OCA:11.0 May 3, 2019
@moylop260
Copy link
Contributor

@etobella
Thanks for finishing the work

Also, I made some tests in order to improve the coverage, maybe it is interesting to apply them on v12 @moylop260

Yes, of course.
Sorry for delay about my PR
Could you help me to finish my own PR or creating another one for v12.0, please?

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants