[12.0][MIG] base_multi_image #1528

ljimenezsidoo · 2019-03-13T16:03:16Z

No description provided.

See OCA/product-attribute#135 (comment).

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

…dule is uninstalled.

pedrobaeza · 2019-03-13T16:11:04Z

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests, and maybe others from same author

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

improve uninstall hook to move images from multi to single mode

base_multi_image/views/image_view.xml

base_multi_image/models/image.py

base_multi_image/views/image_view.xml

florian-dacosta

@acm1pt-colorado Made to suggestion in order to make the module functional with url stored images

base_multi_image/models/image.py

rvalyi · 2019-03-29T18:42:17Z

@sebastienbeau @sbidoul @hparfr worth looking at this PR if we want some compatibility with https://github.com/akretion/storage/tree/10.0/storage_image in v12

ljimenezsidoo · 2019-04-01T08:40:56Z

@florian-dacosta and @canvasMM-odoo1 thansk for the improves

angelmoya · 2019-04-01T14:04:52Z

@florian-dacosta and @canvasMM-odoo1 can you check now?

florian-dacosta

functional review

karan-dreambits · 2019-04-02T13:11:57Z

Runbot seems to be failing due to following warnings and errors:

2019-04-01 14:51:11,152 159 WARNING openerp_test odoo.models: The model base_multi_image.image has no _description
2019-04-01 14:51:11,152 159 WARNING openerp_test odoo.models: The model base_multi_image.owner has no _description
<string>:59: (ERROR/3) Unknown interpreted text role "meth".
<string>:59: (ERROR/3) Unknown interpreted text role "meth".

2019-04-01 14:51:11,457 159 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="1" line="59" source="<string>" type="INFO"><paragraph>No role entry for "meth" in module "docutils.parsers.rst.languages.en".
Trying "meth" as canonical role name.</paragraph></system_message>
2019-04-01 14:51:11,457 159 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message backrefs="id2" ids="id1" level="3" line="59" source="<string>" type="ERROR"><paragraph>Unknown interpreted text role "meth".</paragraph></system_message>
2019-04-01 14:51:11,457 159 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="1" line="59" source="<string>" type="INFO"><paragraph>No role entry for "meth" in module "docutils.parsers.rst.languages.en".
Trying "meth" as canonical role name.</paragraph></system_message>
2019-04-01 14:51:11,457 159 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message backrefs="id4" ids="id3" level="3" line="59" source="<string>" type="ERROR"><paragraph>Unknown interpreted text role "meth".</paragraph></system_message>

ivantodorovich · 2019-05-02T08:02:23Z

@acm1pt-colorado can you please squash transbot commits as @pedrobaeza suggested and fix the runbot warnings/errors.

One of the warning is because the base_multi_image.image and base_multi_image.owner models have no _description attribute.

ljimenezsidoo · 2019-05-31T10:46:07Z

@ivantodorovich
I did the squash before for the transbot i dont know if im missing something. Add _description in both files.

pedrobaeza · 2019-06-04T12:48:14Z

Warnings:

2019-05-31 10:48:19,024 160 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="1" line="59" source="<string>" type="INFO"><paragraph>No role entry for "meth" in module "docutils.parsers.rst.languages.en".
Trying "meth" as canonical role name.</paragraph></system_message>
2019-05-31 10:48:19,025 160 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message backrefs="id2" ids="id1" level="3" line="59" source="<string>" type="ERROR"><paragraph>Unknown interpreted text role "meth".</paragraph></system_message>
2019-05-31 10:48:19,025 160 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="1" line="59" source="<string>" type="INFO"><paragraph>No role entry for "meth" in module "docutils.parsers.rst.languages.en".
Trying "meth" as canonical role name.</paragraph></system_message>
2019-05-31 10:48:19,025 160 WARNING openerp_test odoo.addons.base.models.ir_module: docutils' system message present: <system_message backrefs="id4" ids="id3" level="3" line="59" source="<string>" type="ERROR"><paragraph>Unknown interpreted text role "meth".</paragraph></system_message>

It seems the README is not well formatted.

I still see the transbot commits not squashed. You can use https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

ljimenezsidoo · 2019-06-06T10:03:32Z

Hi @pedrobaeza

I tried to do the squash of the transbot and i dont know if i'm doing something wrong. This is what i did:

git rebase -i origin/10.0
then tried to change the transbot for "f" and only "pick" the last but i have conflicts in readme,travis and gitignore files.

i tried to use last commits but i can not be able to finish the rebase. what i'm missing.

shepilov-vladislav · 2019-08-22T13:51:20Z

@pedrobaeza @acm1pt-colorado I did squash all - #1650

Can we merge it?

pedrobaeza · 2019-08-22T15:24:33Z

Superseeded by #1650

Syncing from upstream OCA/server-tools (17.0)

yajo and others added 30 commits March 7, 2019 16:14

Split model in abstract & concrete.

a94de89

Extend model example.

f693454

Tenames and typos.

a913af3

No default value for storage.

15b3a47

Do not require a name.

6ba219f

Add sequence to images.

9f690e1

Reduce methods.

45ade75

Cache images' URL.

67cad5d

Remove wrong copyright.

6882c41

Add known issues section.

d603285

Fix bug that made previous images to disappear.

ff850d6

See OCA/product-attribute#135 (comment).

OCA Transbot updated translations from Transifex

f686761

OCA Transbot updated translations from Transifex

7745808

[MIG][9.0] base_multi_image

b330b2a

OCA Transbot updated translations from Transifex

374571f

OCA Transbot updated translations from Transifex

c3c24a9

OCA Transbot updated translations from Transifex

3c036ff

OCA Transbot updated translations from Transifex

5d980ad

[FIX] base_multi_image - New storage backend 'Filestore' to link an e…

73f00d8

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

[IMP] base_multi_image - Select only images as attachments

c563440

[FIX] base_multi_image - Clean up + updated comments

b06300f

[FIX] base_multi_image - Make validation error messages translatable

9b2a07f

[FIX] base_multi_image - Fix method name

edba59b

OCA Transbot updated translations from Transifex

261c292

OCA Transbot updated translations from Transifex

bd938d2

Use v9 ormcache.

49050c5

Add a reference field to get to the owner with 1 click.

aee4cab

Add uninstall hook to avoid garbage images hanging around after submo…

e18537b

…dule is uninstalled.

Raise version.

ed82bf3

Add ondelete attribute, required for Many2one fields in v9.

35c5fb6

pedrobaeza added this to the 12.0 milestone Mar 13, 2019

OCA-git-bot mentioned this pull request Mar 13, 2019

Migration to version 12.0 #1368

Closed

32 tasks

oca-transbot and others added 3 commits March 13, 2019 17:45

[10.0] [IMP] base_multi_image: improve uninstall hook (OCA#1286)

24c5355

improve uninstall hook to move images from multi to single mode

[UPD] Update base_multi_image.pot

159aa85

ljimenezsidoo force-pushed the 12.0-mig-base_multi_image branch from f85a250 to f1aec3a Compare March 13, 2019 16:46

canvasMM-odoo1 suggested changes Mar 15, 2019

View reviewed changes

ljimenezsidoo force-pushed the 12.0-mig-base_multi_image branch from f1aec3a to f0d2007 Compare March 20, 2019 12:35

florian-dacosta suggested changes Mar 29, 2019

View reviewed changes

base_multi_image/models/image.py Outdated Show resolved Hide resolved

base_multi_image/models/image.py Outdated Show resolved Hide resolved

ljimenezsidoo force-pushed the 12.0-mig-base_multi_image branch from f0d2007 to 86f0fea Compare April 1, 2019 08:38

angelmoya approved these changes Apr 1, 2019

View reviewed changes

florian-dacosta approved these changes Apr 1, 2019

View reviewed changes

canvasMM-odoo1 approved these changes Apr 2, 2019

View reviewed changes

florian-dacosta mentioned this pull request May 11, 2019

[12.0][MIG] connector_prestashop: Migration to 12.0 OCA/connector-prestashop#112

Closed

Migration to version 12

53c074b

ljimenezsidoo force-pushed the 12.0-mig-base_multi_image branch from 86f0fea to 53c074b Compare May 31, 2019 10:44

shepilov-vladislav mentioned this pull request Aug 22, 2019

[MIG] base_multi_image: Migration to 12.0 #1650

Closed

pedrobaeza closed this Aug 22, 2019

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#1528 from OCA/17.0

c247fa4

Syncing from upstream OCA/server-tools (17.0)

Uh oh!

[12.0][MIG] base_multi_image #1528

[12.0][MIG] base_multi_image #1528

Uh oh!

Conversation

ljimenezsidoo commented Mar 13, 2019

Uh oh!

pedrobaeza commented Mar 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

florian-dacosta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rvalyi commented Mar 29, 2019

Uh oh!

ljimenezsidoo commented Apr 1, 2019

Uh oh!

angelmoya commented Apr 1, 2019

Uh oh!

florian-dacosta left a comment

Choose a reason for hiding this comment

Uh oh!

karan-dreambits commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivantodorovich commented May 2, 2019

Uh oh!

ljimenezsidoo commented May 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Jun 4, 2019

Uh oh!

ljimenezsidoo commented Jun 6, 2019

Uh oh!

shepilov-vladislav commented Aug 22, 2019

Uh oh!

pedrobaeza commented Aug 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

florian-dacosta left a comment •

edited

Loading

karan-dreambits commented Apr 2, 2019 •

edited

Loading

ljimenezsidoo commented May 31, 2019 •

edited

Loading