[12.0][MIG] base_view_inheritance_extension: Migration to 12.0 #1529

rvalyi · 2019-03-14T18:47:56Z

standard migration: nothing to be done: same code as version 11 (except version number)

cc @hbrunn @NL66278 @pedrobaeza @sergio-teruel @alexis-via

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

expression not match the node any more. Fixes OCA#885

* warning about dynamic context * import for safe_eval

alexis-via · 2019-03-14T20:01:13Z

It seems you forgot the update of the version number.

rvalyi · 2019-03-14T20:11:53Z

@alexis-via sorry. I now amended the commit with the right version

rvalyi · 2019-03-14T21:12:45Z

@alexis-via sorry, I did it wrong as I was in a meeting with Renato. I should not have changed the version in the Transiflex pot commit, so I undo that and I added a new commit for it 61a83bb
Should be good now, sorry again.

hbrunn · 2019-03-15T04:00:02Z

v12 has its own version of position="move", cf https://github.com/OCA/OCB/blob/12.0/odoo/addons/base/models/ir_ui_view.py#L650 ff and https://www.odoo.com/documentation/12.0/reference/views.html#inheritance-specs (note at the end).

It seems to me both can coexist, and I find the way they have chosen a little bit clumsy, but it serves the same purpose. Should we drop support for position="move" here for consistency or keep it for simpler migrations of modules using it and a imho nicer syntax?

NL66278 · 2019-03-15T07:17:49Z

@hbrunn I would people encourage to use the standard Odoo way as much as possible. So keep the position="move" for now, but clearly mark/document it as deprecated.

pedrobaeza · 2019-03-15T08:38:00Z

But are they going to conflict having the same name?

hbrunn · 2019-03-15T08:46:58Z

no, because for Odoo standard, the attribute is supposed to be added to a child of the element you match, in our version it's on the element you match

pedrobaeza · 2019-03-15T08:51:55Z

Pretty confusing, isn't it? I prefer to remove it...

bealdav · 2019-03-29T08:49:05Z

Any decision here ?

tbaden · 2019-04-21T17:14:44Z

I would prefer to use odoo core behaviour, but just my opinion. nothing against this feature, but to have both will be quite confusing.

astirpe · 2019-05-28T12:50:03Z

I would prefer the position="move" removed from this module. Just a preference, not blocking for this.

ernestotejeda · 2019-09-04T14:22:55Z

@rvalyi, what conclusion do we get here? What can we do to conclude with this migration?
maybe drop support for position="move" here is good idea, what do you think? ;-)

hbrunn · 2019-09-04T14:40:16Z

note that since version 9, also the list_{add,remove} parts can be done with Odoo core: OCA/OCB@f962b0f (actually in a nicer way because you can also select a separator) - so if we deprecate the moving, we also should deprecate that

ernestotejeda · 2019-09-04T15:00:13Z

note that since version 9, also the list_{add,remove} parts can be done with Odoo core: OCA/OCB@f962b0f (actually in a nicer way because you can also select a separator) - so if we deprecate the moving, we also should deprecate that

Yes, i agree with you @hbrunn 👌

tsabi · 2019-12-01T19:14:13Z

Hi, when will you merge this? A lot of module depends from this.
Thanks, Csaba

NL66278 · 2019-12-02T08:21:13Z

base_view_inheritance_extension/__init__.py

@@ -0,0 +1,2 @@
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).


Make license lines https:

NL66278

I agree that all the methods that are now in standard Odoo should be removed. Either completely, or at least by giving a Deprecated message when still used (to be turned into an Exception in 13.0).

rvalyi · 2019-12-02T21:53:45Z

Hello folks, I dont really use this module myself. So if somebody wants to redo the migration in another PR/another way please feel free to go ahead as I cannot dedicate time to this one these days unfortunately...

alexis-via · 2020-03-02T12:07:26Z

I continued the work of @rvalyi and removed the features which are now native. The readme of the module has been updated. Tests works fine. I also tested it with my PR OCA/account-invoicing#570 which makes use of this module in v12 and it works well. So it's ready to merge now.

bealdav

LGTM

Use https in URL to licence

alexis-via · 2020-03-03T14:24:29Z

As said by Pedro in the PR for v13, the list_add and list_remove feature is NOT native. So I cancelled my previous commit and push a new commit with only the removal of the move feature.
I took into account all the remarks of the reviewers. So it's now ready to merge.

pedrobaeza · 2020-03-03T15:10:07Z

/ocabot merge

OCA-git-bot · 2020-03-03T15:10:29Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1529-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot · 2020-03-03T15:36:34Z

Congratulations, your PR was merged at d4a489f. Thanks a lot for contributing to OCA. ❤️

Syncing from upstream OCA/server-tools (16.0)

hbrunn and others added 9 commits March 14, 2019 15:33

[ADD] base_view_inheritance_extension

80f4789

[base_view_inheritance_extension] Relicense to LGPL. (#4)

ae0f2f1

[MIG] base_view_inheritance_extension: Migration to 9.0

46376b2

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[8.0][ADD] Add list manipulation operations to base_view_inheritance_…

199785e

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

[MIG] base_view_inheritance_extension to 10.0

942eec3

[FIX] don't break when an attribute node in an xpath makes the

da8ae07

expression not match the node any more. Fixes OCA#885

[FIX] base_view_inheritance_extension: 2 things:

feb5168

* warning about dynamic context * import for safe_eval

[UPD] Update base_view_inheritance_extension.pot

3c33bf3

[MIG] base_view_inheritance_extension: Migration to 11.0

2ddfa36

rvalyi force-pushed the 12.0-mig-base_view_inheritance_extension branch from 578d34c to d3e9534 Compare March 14, 2019 20:10

oca-travis and others added 2 commits March 14, 2019 18:07

[UPD] Update base_view_inheritance_extension.pot

0282b38

[MIG] base_view_inheritance_extension: Migration to 12.0

61a83bb

rvalyi force-pushed the 12.0-mig-base_view_inheritance_extension branch from d3e9534 to 61a83bb Compare March 14, 2019 21:10

pedrobaeza added this to the 12.0 milestone Mar 15, 2019

OCA-git-bot mentioned this pull request Mar 15, 2019

Migration to version 12.0 #1368

Closed

32 tasks

hbrunn added the needs review label Mar 15, 2019

astirpe mentioned this pull request May 28, 2019

[12.0][MIG] account_cost_center OCA/account-financial-tools#835

Merged

1 task

pedrobaeza mentioned this pull request Jul 23, 2019

[12.0] account_invoice_transmit_method: use base_view_inheritance_extension OCA/account-invoicing#570

Merged

NL66278 reviewed Dec 2, 2019

View reviewed changes

NL66278 suggested changes Dec 2, 2019

View reviewed changes

pedrobaeza changed the title ~~12.0 mig base view inheritance extension~~ [12.0][MIG] base_view_inheritance_extension: Migration to 12.0 Jan 8, 2020

bealdav approved these changes Mar 2, 2020

View reviewed changes

alexis-via force-pushed the 12.0-mig-base_view_inheritance_extension branch from 4a230fd to 61a83bb Compare March 3, 2020 14:13

Remove the "move" feature which is now native

0268eb2

Use https in URL to licence

pedrobaeza approved these changes Mar 3, 2020

View reviewed changes

OCA-git-bot added the merged 🎉 label Mar 3, 2020

OCA-git-bot merged commit e481f7a into OCA:12.0 Mar 3, 2020

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#1529 from OCA/16.0

f584c28

Syncing from upstream OCA/server-tools (16.0)

		@@ -0,0 +1,2 @@
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).

Uh oh!

[12.0][MIG] base_view_inheritance_extension: Migration to 12.0 #1529

[12.0][MIG] base_view_inheritance_extension: Migration to 12.0 #1529

Conversation

rvalyi commented Mar 14, 2019

Uh oh!

alexis-via commented Mar 14, 2019

Uh oh!

rvalyi commented Mar 14, 2019

Uh oh!

rvalyi commented Mar 14, 2019

Uh oh!

hbrunn commented Mar 15, 2019

Uh oh!

NL66278 commented Mar 15, 2019

Uh oh!

pedrobaeza commented Mar 15, 2019

Uh oh!

hbrunn commented Mar 15, 2019

Uh oh!

pedrobaeza commented Mar 15, 2019

Uh oh!

bealdav commented Mar 29, 2019

Uh oh!

tbaden commented Apr 21, 2019

Uh oh!

astirpe commented May 28, 2019

Uh oh!

ernestotejeda commented Sep 4, 2019

Uh oh!

hbrunn commented Sep 4, 2019

Uh oh!

ernestotejeda commented Sep 4, 2019

Uh oh!

tsabi commented Dec 1, 2019

Uh oh!

NL66278 Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

alexis-via Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

NL66278 left a comment

Choose a reason for hiding this comment

Uh oh!

rvalyi commented Dec 2, 2019

Uh oh!

alexis-via commented Mar 2, 2020

Uh oh!

bealdav left a comment

Choose a reason for hiding this comment

Uh oh!

alexis-via commented Mar 3, 2020

Uh oh!

pedrobaeza commented Mar 3, 2020

Uh oh!

OCA-git-bot commented Mar 3, 2020

Uh oh!

OCA-git-bot commented Mar 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants