Skip to content

[MIG] base_locale_uom_default: Migration to 12.0 #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 6 commits into from
Nov 10, 2020
Merged

[MIG] base_locale_uom_default: Migration to 12.0 #1553

OCA-git-bot merged 6 commits into from
Nov 10, 2020

Conversation

@skukered
Copy link

@skukered skukered commented Apr 8, 2019

No description provided.

@oca-clabot
Copy link

oca-clabot commented Apr 8, 2019

Hey @skukered, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@skukered skukered mentioned this pull request Apr 8, 2019
Closed
@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 8, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 8, 2019
Closed
32 tasks
@oca-clabot
Copy link

oca-clabot commented Apr 27, 2019

Hey @skukered,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

tbaden
tbaden suggested changes May 13, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review:
some changes are required.
please use the fragment readme.

base_locale_uom_default/__manifest__.py Outdated
'language level.',
'version': '12.0.1.0.0',
'category': 'Extra Tools',
'website': 'https://laslabs.com/',
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set https://github.com/OCA/server-tools/ as website

base_locale_uom_default/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

base_locale_uom_default/__manifest__.py Outdated
@@ -0,0 +1,27 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

base_locale_uom_default/models/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

base_locale_uom_default/models/res_lang.py Outdated
@@ -0,0 +1,56 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

base_locale_uom_default/tests/__init__.py Outdated
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

Copy link
Member

@tbaden tbaden May 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed that one @skukered

Copy link
Author

@skukered skukered May 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... Done

base_locale_uom_default/tests/test_res_lang.py Outdated
@@ -0,0 +1,45 @@
# -*- coding: utf-8 -*-
Copy link
Member

@tbaden tbaden May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line. no longer needed

@skukered
Copy link
Author

skukered commented May 14, 2019

@tbaden changes done.

@skukered skukered force-pushed the 12.0-mig-base_locale_uom_default branch from 2e42fbd to 3aaed8c Compare May 14, 2019 16:04
benbrich
benbrich approved these changes Oct 31, 2020
View reviewed changes
Copy link

@benbrich benbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just just stumbled over this one and did a functional check. Everything seems to work like it should. Thumbs up & thanks for the work. Let's get this pr done

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 31, 2020

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Nov 10, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 10, 2020

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1553-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 10, 2020

Congratulations, your PR was merged at b99971b. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit e1cd6a1 into OCA:12.0 Nov 10, 2020
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1553 from OCA/17.0
14bfeee 
Syncing from upstream OCA/server-tools (17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tbaden tbaden tbaden approved these changes

@benbrich benbrich benbrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

10 participants

@skukered @oca-clabot @OCA-git-bot @dreispt @tbaden @benbrich @pedrobaeza @lasley @oca-transbot @oca-travis