Skip to content

Conversation

@sebalix
Copy link
Contributor

@sebalix sebalix commented Apr 9, 2019

Supersedes #1392

I know several PR were opened to migrate this module, and the existing one #1392 broke the history of the repository.

This PR also set all rule fields as readonly when the rule is subscribded.

sebalix and others added 30 commits April 9, 2019 11:44
…itlog.log' model (standard 'create_date' field is used instead)
…ail data - if any - are migrated during the installation)
… 'field_description' fields changed into related fields
@sebalix sebalix mentioned this pull request Apr 9, 2019
32 tasks
@pedrobaeza pedrobaeza mentioned this pull request Apr 9, 2019
@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 9, 2019
Copy link

@Tonow-c2c Tonow-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<field name='name'>Auto-vacuum audit logs</field>
<field name='interval_number'>1</field>
<field name='interval_type'>days</field>
<field name="numbercall">-1</field>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to know why -1 ?

_order = "create_date DESC"

display_name = fields.Char(
"Name", compute="_compute_display_name", store=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer in multi line but it's ok like this

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some commits could be squashed to reduce history. Anyway 👍

@sebalix
Copy link
Contributor Author

sebalix commented Apr 10, 2019

@chienandalu I squashed translations ones the best I could, about the others I don't know if it's easy (to keep authorship especially).

@chienandalu
Copy link
Member

Well, yeah, I meant consecutive commits of the same author :)

@sebalix sebalix force-pushed the 12.0-mig-auditlog branch from 7cd84ed to c6a3060 Compare April 10, 2019 08:31
@max3903 max3903 merged commit 88bf4ec into OCA:12.0 Apr 10, 2019
@sebalix sebalix deleted the 12.0-mig-auditlog branch April 11, 2019 07:31
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.