[MIG] dbfilter_from_header: Migration to 12.0 #1558
Conversation
|
👍 I've tested it. It works fine on v12 |
tbaden
left a comment
tbaden
left a comment
There was a problem hiding this comment.
thanks for the work 👍
I did a code review, just some small changes are needed (see below)
dbfilter_from_header/__manifest__.py
Outdated
| ], | ||
| "data": [ | ||
| ], | ||
| "js": [ |
There was a problem hiding this comment.
if you dont use the tag, just delete it.
| if config.get('proxy_mode') and \ | ||
| 'dbfilter_from_header' in config.get('server_wide_modules'): | ||
| _logger = logging.getLogger(__name__) | ||
| _logger.info('monkey patching http.db_filter') |
There was a problem hiding this comment.
it works this way in the previous versions
|
@remytms could you have a quick look to make the few requested changes ? |
|
Yes, I will fix that as soon as possible. :) |
remytms
force-pushed
the
12.0-mig-dbfilter_from_header
branch
from
7f1158d to
981593b
Compare
|
@tbaden I have split the readme according to maintainer-tools and fixed empty keys in manifest. :) |
| "version": "12.0.1.0.0", | ||
| "author": "Therp BV, " | ||
| "Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", |
There was a problem hiding this comment.
please add the website tag with the value: https://github.com/OCA/server-tools
remytms
force-pushed
the
12.0-mig-dbfilter_from_header
branch
from
981593b to
317e751
Compare
|
@tbaden website tag added. Thanks for your attentive review. |
|
@houssine78 Can you approve this PR, if it seams good to you ? :) |
[MIG] migrate dbfilter_from_header to 10.0 I have also removed the ability to use HTTP_X_OPENERP_DBFILTER
updates were made in OCA#1137 by @TimLai125 and small lint fixes by @yelizariev
pedrobaeza
force-pushed
the
12.0-mig-dbfilter_from_header
branch
from
317e751 to
a183841
Compare
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 32d5666. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Syncing from upstream OCA/server-tools (16.0)
10 participants
This migrates the module
dbfilter_from_headerto 12.0.There is a refactor that was proposed to 11.0: #1340.
Should we wait before the refactor is merge into 11.0 or can we migrate this module to 12.0 and than migrate the changes from 11.0 to 12.0 ?