Skip to content

12.0 fontawesome #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedrobaeza merged 10 commits into from
Jun 4, 2019
Merged

12.0 fontawesome #1587

pedrobaeza merged 10 commits into from
Jun 4, 2019

Conversation

@etobella
Copy link
Member

@etobella etobella commented May 29, 2019

Standard migration.

Uses the same code from the PR #1500

AdriaGForgeFlow
AdriaGForgeFlow approved these changes May 29, 2019
View reviewed changes
Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍

jarroyomorales
jarroyomorales approved these changes Jun 3, 2019
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 3, 2019

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 4, 2019
@pedrobaeza pedrobaeza merged commit c7de33d into OCA:12.0 Jun 4, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 4, 2019
Closed
32 tasks
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1587 from OCA/16.0
2927625 
Syncing from upstream OCA/server-tools (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@etobella @OCA-git-bot @AdriaGForgeFlow @jarroyomorales @pedrobaeza @simahawk @oca-travis