Skip to content

Conversation

@HviorForgeFlow
Copy link
Member

Superseed #1393 due to get no answer on #1393 (comment)

CC @eficent

Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 3, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 3, 2019
32 tasks
@HviorForgeFlow HviorForgeFlow force-pushed the 12.0-mig-base_cron_exclusion branch from a071da0 to 5e17883 Compare June 4, 2019 11:36
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-1593-by-jbeficent-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 946544f. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jul 9, 2019
Signed-off-by jbeficent
@OCA-git-bot OCA-git-bot closed this Jul 9, 2019
@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-base_cron_exclusion branch July 9, 2019 13:31
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.