Skip to content

[FIX][#1580]database_cleanup: Skip studio_customization module skippe… #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bizzappdev wants to merge 1 commit into from
Closed

[FIX][#1580]database_cleanup: Skip studio_customization module skippe… #1632

bizzappdev wants to merge 1 commit into from

Conversation

@bizzappdev
Copy link
Contributor

@bizzappdev bizzappdev commented Aug 5, 2019

…d for uninstalling

FIX #1580

sswapnesh
sswapnesh reviewed Aug 7, 2019
View reviewed changes
@bizzappdev bizzappdev force-pushed the 12.0-FIX-1580-studio_customization_module-skip-purge branch from 5cd7ead to 7880fcd Compare August 8, 2019 06:13
@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 8, 2019

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 8, 2019

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-1632-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 8, 2019

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1632-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@bizzappdev bizzappdev force-pushed the 12.0-FIX-1580-studio_customization_module-skip-purge branch from 7880fcd to a06ddbc Compare August 9, 2019 05:26
@bizzappdev
Copy link
Contributor Author

bizzappdev commented Aug 9, 2019

rebase done

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 9, 2019

And there's a linter error:

database_cleanup/models/purge_modules.py:68:80: E501 line too long (80 > 79 characters)

@bizzappdev bizzappdev force-pushed the 12.0-FIX-1580-studio_customization_module-skip-purge branch from a06ddbc to 4525cda Compare August 9, 2019 07:24
@bizzappdev
Copy link
Contributor Author

bizzappdev commented Aug 11, 2019

@pedrobaeza Pylint error solved.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 11, 2019

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 11, 2019

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 11, 2019

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-1632-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 11, 2019

Congratulations, your PR was merged at 5157720. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Aug 11, 2019
@OCA-git-bot
Merge PR #1632 into 12.0
5157720 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot changed the title [FIX][#1580]database_cleanup: Skip studio_customization module skippe… [FIX][#1580]database_cleanup: Skip studio_customization module skippe… Aug 11, 2019
@sswapnesh sswapnesh mentioned this pull request Aug 11, 2019
Closed
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#1632 from OCA/18.0
7d2261e 
Syncing from upstream OCA/server-tools (18.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+2 more reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@sswapnesh sswapnesh sswapnesh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

database cleanup delete views and fields created by odoo studion!

5 participants

@bizzappdev @pedrobaeza @OCA-git-bot @ivantodorovich @sswapnesh