Skip to content

Conversation

@asaunier
Copy link
Contributor

@asaunier asaunier commented Aug 7, 2019

Ported migration to 11.0 whose PR is available at #1411

mdietrichc2c and others added 6 commits August 7, 2019 16:45
* Add new module "mail_cleanup" in order to move/mark as read old messages

* Use correct Model + remove unnecessary conditions/assignments

* Add purging mechanism + cleanup is by default inactive

* Add new field + new info in README

* Correct type for purge_days + better checks

* Place expunge() call after parsing all messages

* Migration to 9.0 of mail_cleanup

* Fix README.rst

* Add __init__.py

* Fix error with multi mail servers

* Correct syntax for methods + use datetime.date.today
@asaunier asaunier mentioned this pull request Aug 7, 2019
32 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 7, 2019
@sebalix
Copy link
Contributor

sebalix commented Aug 8, 2019

@asaunier add server-env to a oca_dependencies.txt file at the root of the repository (like here: https://github.com/OCA/sale-workflow/blob/12.0/oca_dependencies.txt), as mail_cleanup depends on mail_environment which is hosted in OCA/server-env now.

@asaunier
Copy link
Contributor Author

asaunier commented Aug 9, 2019

@sebalix Thanks a lot for the hint!

Now we have the same code coverage issue than for the 11.0 PR #1411 :P

- git clone --depth=1 https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools
- export PATH=${HOME}/maintainer-quality-tools/travis:${PATH}
- travis_install_nightly
- printf '[options]\n\nrunning_env = dev\n' > ${HOME}/.openerp_serverrc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need thaht ?, .openerp_serverrc seems pretty old for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this change at ff29eeb to fix errors reported by Travis at https://travis-ci.org/OCA/server-tools/builds/569737181?utm_source=github_status&utm_medium=notification

  File "/home/travis/dependencies/server-env/server_environment/serv_config.py", line 50, in <module>
1599    "The parameter 'running_env' has not be set neither in base config "
1600Exception: The parameter 'running_env' has not be set neither in base config file option -c or in openerprc.
1601We strongly recommend against using the rc file but instead use an explicit config file with this content:
1602[options]
1603running_env = dev

I don't remember exactly where but I found this .travis.yml line in one of C2C's (not that old?) projects and it seems to do the job :)

Copy link
Contributor Author

@asaunier asaunier Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to use .odoo_serverrc (see 4aa7f03) but not sure it really exists, I have found no occurence of it) or .odoorc (see e86e9b1). But with no success.

Copy link

@Tonow-c2c Tonow-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code review

@dreispt
Copy link
Member

dreispt commented Apr 30, 2021

Please resolve conflicts

@gdgellatly
Copy link
Contributor

This PR is no longer relevant, module long since migrated.

@gdgellatly gdgellatly closed this Feb 4, 2022
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (18.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.